Added Status Code Lists for HTTP Query State #55145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
dwoz
approved these changes
Dec 26, 2019
Contributor
dwoz
left a comment
dwoz
left a comment
There was a problem hiding this comment.
@Ajnbro This would be a good case to start refactoring things into smaller checks. If the match and status checks were individual methods, they could be more easily unit tested without having to mock the http response. If you have some time to dedicated to this, it would be fantastic.
Otherwise, approved for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows for individuals to pass a list of strings representing multiple different status codes to the HTTP State for querying in order to check if any of the provided status codes are returned by the query. It also creates two additional tests for the HTTP Query State, one for testing this new functionality and one for testing prior functionality. Repost of #55132 because I had opened the PR against the develop branch initially.
What issues does this PR fix or reference?
N/A
Previous Behavior
HTTP Query only allowed individuals to specify the status parameter as a string representing a status code or as a regex used to search for specific status codes.
New Behavior
HTTP Query allows individuals to specify the status parameter as a string representing a status code, a list of strings representing multiple status codes, or as a regex used to search for specific status codes.
Tests written?
Yes
Commits signed with GPG?
Yes