[master] Port #49891 (salt_version module)#55195
Merged
Merged
Conversation
ghost
requested a review
from 
max-arnold
force-pushed
the
salt-version-module
branch
from
7c864de to
dd0421d
Compare
waynew
suggested changes
Nov 4, 2019
Contributor
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
The code looks good, but with the change to 3000-based versions, we probably should update the docs.
max-arnold
force-pushed
the
salt-version-module
branch
2 times, most recently
from
d38bc25 to
714cb8a
Compare
max-arnold
force-pushed
the
salt-version-module
branch
2 times, most recently
from
fb943b3 to
525a7b9
Compare
Contributor
Author
|
@waynew Does the tweaked first paragraph look good? |
max-arnold
force-pushed
the
salt-version-module
branch
from
525a7b9 to
089d0bf
Compare
dwoz
approved these changes
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master backport of #49891 (
salt_versionexecution module).Also, fixed the
LNAMESmocks (indexes should be lowercase, the mocked tests passed by accident) and changed the function names and semantics: