Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool deleted state #55200

Merged
merged 2 commits into from Dec 19, 2019
Merged

pool deleted state #55200

merged 2 commits into from Dec 19, 2019

Conversation

cbosdo
Copy link
Collaborator

@cbosdo cbosdo commented Nov 5, 2019

What does this PR do?

Add a virt.pool_deleted state to use to ensure a virtual storage pool and optionally its volumes are deleted. This state handles the various libvirt storage backends specific implementations to avoid triggering exceptions if an function is not implemented on the libvirt side.

Tests written?

Yes

Commits signed with GPG?

Yes

@cbosdo cbosdo requested a review from as a code owner Nov 5, 2019
@ghost ghost requested a review from cmcmarrow Nov 5, 2019
@cbosdo
Copy link
Collaborator Author

@cbosdo cbosdo commented Nov 5, 2019

Note that this PR is based on PR #54475

@cbosdo cbosdo force-pushed the master-pool-deleted-state branch 2 times, most recently from d3b3112 to 75da553 Compare Nov 5, 2019
There are two reasons to remove this parameter without deprecating it:
 * the meaning has been mistakenly inversed
 * fast=True will raise an exception for every libvirt storage backend
since that flag has never been implemented in any of those.

Fixes issue saltstack#54474
@cbosdo cbosdo force-pushed the master-pool-deleted-state branch from 75da553 to caa4f52 Compare Dec 6, 2019
The new virt.pool_deleted state takes care of removing a virtual storage
pool and optionally the contained volumes.
@cbosdo cbosdo force-pushed the master-pool-deleted-state branch from caa4f52 to d2194f0 Compare Dec 16, 2019
dwoz
dwoz approved these changes Dec 19, 2019
@dwoz dwoz merged commit 6b8fa5c into saltstack:master Dec 19, 2019
49 checks passed
@cbosdo cbosdo deleted the master-pool-deleted-state branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants