Skip to content

Btrfs and XFS as supported fstypes - #55209

Merged
dwoz merged 12 commits into
saltstack:masterfrom
brejoc:master-additional-fs-types
Apr 13, 2020
Merged

Btrfs and XFS as supported fstypes#55209
dwoz merged 12 commits into
saltstack:masterfrom
brejoc:master-additional-fs-types

Conversation

@brejoc

@brejoc brejoc commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

What does this PR do?

Btrfs and XFS are supported by parted and mkfs. Adding them to the list.

This PR replaces #53126

Previous Behavior

btrfs and xfs where not supported for parted and mkfs.xxx.

New Behavior

btrfs and xfs are now supported.

Tests written?

Yes

Commits signed with GPG?

Yes

@brejoc
brejoc requested a review from a team as a code owner November 5, 2019 15:54
@brejoc brejoc changed the title Master additional fs types Btrfs and XFS as supported fstypes Nov 5, 2019
@ghost
ghost requested a review from waynew November 5, 2019 16:01
waynew
waynew previously approved these changes Dec 27, 2019

@waynew waynew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brejoc thanks for the PR! Looks great!

@waynew

waynew commented Jan 2, 2020

Copy link
Copy Markdown
Contributor

Hey @brejoc looks like there's a conflict - could you take a look at that? Thanks!

@s0undt3ch

Copy link
Copy Markdown
Contributor

This PR is passing. The pending CentOS 8 build is an artifact of a bad Jenkins job.

@s0undt3ch

Copy link
Copy Markdown
Contributor

Oh, dam. There's conflicts.

@s0undt3ch

Copy link
Copy Markdown
Contributor

Conflicts resolved on the GH UI.

@brejoc

brejoc commented Jan 7, 2020

Copy link
Copy Markdown
Contributor Author

Sorry guys, I was on vacation. And thanks for solving the conflict. I've just merged master into this branch again, to get the latest changes.

@brejoc

brejoc commented Jan 8, 2020

Copy link
Copy Markdown
Contributor Author

Okay, I think this doesn't look bad. I don't know where that failure on ci/py2/amazon1 is coming from. The tests seem to have passed: Test Result (no failures)

@brejoc

brejoc commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

Merged master again. Is there anything that prevents us from merging this?

DmitryKuzmenko
DmitryKuzmenko previously approved these changes Apr 2, 2020
@DmitryKuzmenko DmitryKuzmenko self-assigned this Apr 2, 2020
@brejoc
brejoc dismissed stale reviews from DmitryKuzmenko and waynew via f64a6d2 April 8, 2020 07:01
@brejoc
brejoc requested a review from DmitryKuzmenko April 8, 2020 07:02
@brejoc

brejoc commented Apr 8, 2020

Copy link
Copy Markdown
Contributor Author

Changes are now blacked.

@dwoz
dwoz merged commit 779182e into saltstack:master Apr 13, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ZRelease-Sodium retired label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants