virt: adding kernel boot parameters to libvirt xml#55245
Merged
Conversation
ghost
requested a review
from 
cbosdo
suggested changes
Nov 21, 2019
Contributor
cbosdo
left a comment
cbosdo
left a comment
There was a problem hiding this comment.
Looking good to me, but I would add remote kernel/initrd download.
Contributor
|
re-run full all |
larrydewey
changed the title
cbosdo
suggested changes
Dec 16, 2019
cbosdo
reviewed
Dec 19, 2019
Author
|
|
larrydewey
changed the title
Codecov Report
@@ Coverage Diff @@
## master #55245 +/- ##
=========================================
Coverage ? 18.79%
=========================================
Files ? 822
Lines ? 175254
Branches ? 37710
=========================================
Hits ? 32930
Misses ? 139680
Partials ? 2644
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #55245 +/- ##
=========================================
Coverage ? 18.79%
=========================================
Files ? 822
Lines ? 175254
Branches ? 37710
=========================================
Hits ? 32930
Misses ? 139680
Partials ? 2644
|
added 2 commits
December 27, 2019 09:42
SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com>
Signed-off-by: Larry Dewey <ldewey@suse.com>
Author
|
The tests which failed were a result of issues with the test (one with a Java memory issue, the other with being unable to reach a required resource) and not with the code. Should be ready to merge in. |
Contributor
|
I've re-started the two failing builds, let's see how they run. |
dwoz
approved these changes
Jan 1, 2020
admd
pushed a commit
to admd/salt-1
that referenced
this pull request
Jan 27, 2020
…altstack#197) * virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh
pushed a commit
to meaksh/salt
that referenced
this pull request
Mar 10, 2020
…altstack#197) * virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Apr 22, 2020
…altstack#197) * virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh
pushed a commit
to meaksh/salt
that referenced
this pull request
Apr 22, 2020
…altstack#197) * virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Apr 27, 2020
…altstack#197) * virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
meaksh
pushed a commit
to meaksh/salt
that referenced
this pull request
Apr 13, 2021
…altstack#197) * virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jun 25, 2021
…altstack#197) * virt: adding kernel boot parameters to libvirt xml SUSE's autoyast and Red Hat's kickstart take advantage of kernel paths, initrd paths, and kernel boot command line parameters. These changes provide the option of using these, and will allow salt and autoyast/kickstart to work together. Signed-off-by: Larry Dewey <ldewey@suse.com> * virt: Download linux and initrd Signed-off-by: Larry Dewey <ldewey@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the kernel path, initrd path, and kernel boot command line parameters to libvirt xml for use with SUSE's autoyast and Red Hat's kickstart.
What issues does this PR fix or reference?
N/A
New Behavior
Adds an additional parameter 'boot=None' to a number of functions, allowing the kernel path, the initrd path, and the kernel boot command line string to be parse and added to the xml.
Tests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes
Commits signed with GPG?
Yes