Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aptpkg.info return only installed packages #55258

Merged
merged 1 commit into from Dec 2, 2019

Conversation

mateiw
Copy link
Contributor

@mateiw mateiw commented Nov 11, 2019

What does this PR do?

Port of #51576 to master.

What issues does this PR fix or reference?

None.

Previous Behavior

pkg.info_instaled returned also packages in status rc or pn.

New Behavior

pkg.info_instaled returnes only packages in ii or hi.

Tests written?

Yes

Commits signed with GPG?

No

@mateiw mateiw requested a review from as a code owner Nov 11, 2019
@ghost ghost requested a review from DmitryKuzmenko Nov 11, 2019
@mateiw mateiw force-pushed the master-aptpkg-info-only-installed branch from 9d1a130 to 9d06636 Compare Nov 12, 2019
Copy link
Contributor

@waynew waynew left a comment

Just some minor picks, otherwise this seems reasonable.

tests/unit/modules/test_aptpkg.py Outdated Show resolved Hide resolved
tests/unit/modules/test_aptpkg.py Outdated Show resolved Hide resolved
On debian systems a package can have several other states apart from installed (ii or hi),
 like rc (removed but config files present) or pn (purged not installed).
 This returns only installed packages (ii or hi).
@mateiw mateiw force-pushed the master-aptpkg-info-only-installed branch from 9d06636 to e20362f Compare Nov 20, 2019
@mateiw
Copy link
Contributor Author

@mateiw mateiw commented Nov 20, 2019

@waynew thanks for the suggestions, I've updated the unit test.

@mateiw mateiw requested a review from waynew Nov 20, 2019
dwoz
dwoz approved these changes Dec 2, 2019
@dwoz dwoz merged commit c883fa4 into saltstack:master Dec 2, 2019
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants