Make aptpkg.info return only installed packages #55258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
waynew
reviewed
Nov 12, 2019
Contributor
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Just some minor picks, otherwise this seems reasonable.
On debian systems a package can have several other states apart from installed (ii or hi), like rc (removed but config files present) or pn (purged not installed). This returns only installed packages (ii or hi).
Contributor
Author
|
@waynew thanks for the suggestions, I've updated the unit test. |
dwoz
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Port of #51576 to master.
What issues does this PR fix or reference?
None.
Previous Behavior
pkg.info_instaledreturned also packages in statusrcorpn.New Behavior
pkg.info_instaledreturnes only packages iniiorhi.Tests written?
Yes
Commits signed with GPG?
No