chroot: add apply_, sls and highstate for state execution - #55345
Merged
Conversation
ghost
requested a review
from twangboy
November 18, 2019 14:03
aplanas
changed the title
Contributor
Author
|
This commit is on top of #54959. If this gets merged, I will rebase this one. |
aplanas
force-pushed
the
fix_chroot
branch
2 times, most recently
from
November 18, 2019 14:54
a42e4fe to
a239990
Compare
Akm0d
added
the
Feature
Contributor
|
re-run full pycryptodomex |
Akm0d
reviewed
Nov 20, 2019
Contributor
|
I don't imagine the |
Contributor
Author
I will do this. Thanks for the reviews!!!! |
Also reformulate one test to avoid random ordering of kwargs parameters.
Some bug in Salt is preventing to use `archive.tar` inside chroot, we we want to untar the salt_thin.tgz. This bug is related with how much deep is the stack of __salt__ calls, and do not clossing some connections to the master. Tracking the AsyncZeroMQChannel connections to master:4506, we can see that one is not closed once the actions ends, hanging the salt-call CLI. This commit will be reverted once the root cause in found, and the bug fixed.
Based on the code from the SSH client wrapper, add apply_, sls and highstate for the execution of Salt states inside a chroot environment.
dwoz
approved these changes
Dec 3, 2019
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Based on the code from the SSH client wrapper, add apply_, sls and highstate for the execution of Salt states inside a chroot environment.
Tests written?
Yes