Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding DNS exec and state modules to master #55424

Merged
merged 5 commits into from Dec 9, 2019

Conversation

nicholasmhughes
Copy link
Member

@nicholasmhughes nicholasmhughes commented Nov 25, 2019

What does this PR do?

Add Azure DNS modules for crud operations on DNS zones and record sets.

What issues does this PR fix or reference?

N/A

Tests written?

Yes

Commits signed with GPG?

Yes

PORTING TO MASTER FROM #47945

@nicholasmhughes nicholasmhughes requested a review from as a code owner Nov 25, 2019
@ghost ghost requested a review from xeacott Nov 25, 2019
@nicholasmhughes
Copy link
Member Author

@nicholasmhughes nicholasmhughes commented Nov 25, 2019

@Akm0d , I entered this PR into your tracking spreadsheet

@Akm0d Akm0d added this to PR needs merge to master in PRs to port to master via automation Nov 26, 2019
@Akm0d Akm0d added this to the Approved milestone Nov 26, 2019
Akm0d
Akm0d approved these changes Nov 26, 2019
@Akm0d Akm0d self-assigned this Nov 26, 2019
@dwoz dwoz requested a review from Akm0d Dec 3, 2019
@dwoz dwoz added the Needs-Testcase label Dec 3, 2019
@nicholasmhughes
Copy link
Member Author

@nicholasmhughes nicholasmhughes commented Dec 6, 2019

@Akm0d I added some tests. Let me know what you think.

Akm0d
Akm0d approved these changes Dec 9, 2019
@dwoz dwoz merged commit fee49b9 into saltstack:master Dec 9, 2019
46 checks passed
PRs to port to master automation moved this from PR needs merge to master to PR merged Dec 9, 2019
@nicholasmhughes nicholasmhughes deleted the add-azurearm-dns-modules branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master-port Needs-Testcase
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants