Don't remove one directory level from slspath (master branch) #55434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks the tpldir jinja context variable for the cases where there is an SLS path in the format `X.X` (e.g. `foo.foo`, `bar.bar`, etc.). It also conflicts with the stated documentation for this parameter in `doc/rev/states/vars.rst`, which states that this variable should be the path to the SLS target. In reality this is passed in via `context['sls']` and already has the correct path. If I were to wager a guess, I would say that it's likely that the way `context['sls']` is formulated has changed at some point since these two lines were added in 2014, making these two lines unnecessary.
ghost
requested a review
from 
Contributor
|
re-run full centos |
dwoz
approved these changes
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same fix as #55433, opened against the master branch.