Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the possibility to also use downloadonly in kwargs #55448

Merged
merged 6 commits into from Dec 2, 2019

Conversation

brejoc
Copy link
Collaborator

@brejoc brejoc commented Nov 27, 2019

What does this PR do?

This is the same as #54793, but for master.

The download_only parameter in the apt module is not in line with the yum and zypper modules. Both of them use downloadonly without the underline.

With this change apt now additionally supports the downloadonly parameter.

What issues does this PR fix or reference?

Fixes #54790

Previous Behavior

The apt module had to be used with download_only.

New Behavior

The apt module can now also be used with downloadonly.

Tests written?

Yes

Commits signed with GPG?

Yes

brejoc added 6 commits Nov 27, 2019
The download_only parameter in the apt module is not in line with
the yum and zypper modules. Both of them use downloadonly without
the underline.

With this change apt now additionally supports the downloadonly
parameter.

Fixes saltstack#54790
This will be cleaned up later.
… and removal of debug prints
@brejoc brejoc requested a review from as a code owner Nov 27, 2019
@ghost ghost requested a review from cmcmarrow Nov 27, 2019
@brejoc brejoc changed the title Master download only fix Adds the possibility to also use downloadonly in kwargs Nov 27, 2019
Akm0d
Akm0d approved these changes Nov 27, 2019
@Akm0d Akm0d added this to Backlog in Neon Nov 27, 2019
@Akm0d Akm0d added this to the Approved milestone Nov 27, 2019
dwoz
dwoz approved these changes Dec 2, 2019
@dwoz dwoz merged commit bc0f924 into saltstack:master Dec 2, 2019
47 of 49 checks passed
@@ -1048,7 +1049,7 @@ def upgrade(refresh=True, dist_upgrade=False, **kwargs):
cmd.append('--force-yes')
if kwargs.get('skip_verify', False):
cmd.append('--allow-unauthenticated')
if kwargs.get('download_only', False):
if kwargs.get('download_only', False) or kwargs.get('downloadonly', False):
Copy link
Contributor

@Akm0d Akm0d Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a deprecation warning here too log.warning('download_only will be deprecated in a future release') as described in #54790

Copy link
Collaborator Author

@brejoc brejoc Dec 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akm0d Do we want to deprecate it?

@brejoc brejoc deleted the master-download-only-fix branch Jan 8, 2020
@sagetherage sagetherage moved this from Backlog to Done in Neon Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Neon
  
Done
Development

Successfully merging this pull request may close these issues.

4 participants