Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Blob ext_pillar #55493

Merged
merged 35 commits into from
Apr 27, 2020
Merged

Azure Blob ext_pillar #55493

merged 35 commits into from
Apr 27, 2020

Conversation

Ajnbro
Copy link
Contributor

@Ajnbro Ajnbro commented Dec 2, 2019

What does this PR do?

This PR creates an external pillar interface for Microsoft Azure Blob Storage.

What issues does this PR fix or reference?

#54374

Tests written?

Yes

Commits signed with GPG?

Yes

@Ajnbro Ajnbro requested a review from a team as a code owner December 2, 2019 21:36
@ghost ghost requested a review from twangboy December 2, 2019 21:36
@Akm0d Akm0d added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Dec 2, 2019
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #55493 into master will increase coverage by 17.89%.
The diff coverage is 21.38%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #55493       +/-   ##
===========================================
+ Coverage   19.85%   37.74%   +17.89%     
===========================================
  Files         864     1462      +598     
  Lines      192716   259381    +66665     
  Branches    41665    54912    +13247     
===========================================
+ Hits        38251    97879    +59628     
+ Misses     150846   150638      -208     
- Partials     3619    10864     +7245
Flag Coverage Δ
#archlts ?
#centos7 ?
#cloud ?
#macosxmojave 37.74% <21.38%> (?)
#proxy ?
#py2 37.74% <21.38%> (+19.17%) ⬆️
#py3 ?
#runtests 37.74% <21.38%> (+17.89%) ⬆️
#ubuntu1604 ?
#zeromq 37.74% <21.38%> (+18.97%) ⬆️
Impacted Files Coverage Δ
salt/pillar/azureblob.py 21.38% <21.38%> (ø)
salt/transport/frame.py 21.22% <0%> (-56.06%) ⬇️
salt/utils/smb.py 19.84% <0%> (-39.27%) ⬇️
salt/cloud/clouds/linode.py 13.59% <0%> (-36.68%) ⬇️
salt/modules/dummyproxy_service.py 46.16% <0%> (-35.89%) ⬇️
salt/cloud/clouds/digitalocean.py 11.14% <0%> (-35.86%) ⬇️
salt/cloud/clouds/azurearm.py 7.74% <0%> (-31.61%) ⬇️
salt/utils/cloud.py 12.36% <0%> (-29.12%) ⬇️
salt/utils/stringio.py 52.39% <0%> (-28.57%) ⬇️
salt/utils/vt.py 10.76% <0%> (-28.27%) ⬇️
... and 1160 more

@Akm0d Akm0d removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Feb 12, 2020
@Akm0d Akm0d self-assigned this Feb 12, 2020
@Akm0d Akm0d added this to the Approved milestone Feb 12, 2020
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b7ed02c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55493   +/-   ##
=========================================
  Coverage          ?   37.74%           
=========================================
  Files             ?     1462           
  Lines             ?   259381           
  Branches          ?    54912           
=========================================
  Hits              ?    97879           
  Misses            ?   150638           
  Partials          ?    10864
Flag Coverage Δ
#macosxmojave 37.74% <0%> (?)
#py2 37.74% <0%> (?)
#runtests 37.74% <0%> (?)
#zeromq 37.74% <0%> (?)

@Akm0d
Copy link
Contributor

Akm0d commented Feb 20, 2020

re-run full windows2019

@Ch3LL Ch3LL removed the request for review from a team April 15, 2020 14:31
@Akm0d
Copy link
Contributor

Akm0d commented Apr 16, 2020

@Ajnbro It looks like pre-commit is failing, i'm very sure that it's becasue we recently switched to black over pylint, can you blacken your PR so we can get this merged? Thanks :)

@Akm0d
Copy link
Contributor

Akm0d commented Apr 24, 2020

One last pre-commit error The module at salt/pillar/azureblob.py does not have a sphinx stub at doc/ref/pillar/all/salt.pillar.azureblob.rst

@dwoz dwoz merged commit 507998c into saltstack:master Apr 27, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants