Use ss filter to match TCP connections on Linux#55501
Merged
Merged
Conversation
added 4 commits
December 3, 2019 13:55
Parsing the output of all TCP connections might be really slow for high number of connections. This patch address the problem using the filtering provided by `ss` to reduce the number of line returned by the command. Fixes saltstack#53580
Fix the wrong parameter passed to the function
Fix all the variables and other problems found during the CI Lint pass
Make codeclimate happy about not going too deep into indentation
ghost
requested a review
from 
cifvts
changed the title
dwoz
approved these changes
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current implementation of
_netlink_tool_remote_oncause high CPU usage and is slow if the number of TCP connection is high. This patch address the problem by using the filtering options available inssto reduce the output returned to just the TCP connection we are interested in.What issues does this PR fix or reference?
Fixes #53580
Previous Behavior
salt-minionorsalt-callare slow and CPU intesive when usingstatus.masterNew Behavior
The response of the call is immediate, low CPU usage
Tests written?
A test was written for the function but was not correct. A parameter has been fixed.