Add hmac_compute (Repost of #54164)#55506
Merged
Merged
Conversation
ghost
requested a review
from 
waynew
suggested changes
Dec 4, 2019
waynew
left a comment
waynew
left a comment
Contributor
There was a problem hiding this comment.
If this is going into master, in particular if it's targeted to land before Sodium, we'll need to update this PR to maintain Python2 compatibility.
Contributor
Author
|
@waynew All done :) |
waynew
approved these changes
Dec 5, 2019
waynew
left a comment
waynew
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just needs a rebase onto master
dwoz
requested changes
Dec 6, 2019
Akm0d
approved these changes
Dec 12, 2019
Contributor
|
re-run full macosxmojave |
dwoz
approved these changes
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a util and a module called hmac_compute for computing a HMAC SHA256 hexdigest using a string and secret. Additionally, it updates the base64_encodestring and base64_decodestring util and module functions so that they are compatible with Python 3. This was previously accepted and labeled as merge ready in the PR referenced below; however, it was just closed because it was opened against the develop branch.
What issues does this PR fix or reference?
#54164
Tests written?
Yes
Commits signed with GPG?
Yes