Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backport 51704) parted: fix set_ valid flags comment #55515

Merged
merged 4 commits into from Jan 1, 2020

Conversation

aplanas
Copy link
Collaborator

@aplanas aplanas commented Dec 5, 2019

What does this PR do?

Fix a trivial mistake in a doc comment

Tests written?

Not required, is a comment

(backport #51704, already merged in develop, on top of #54966)

Copy link
Contributor

@dwoz dwoz left a comment

@aplanas The test failures seem to be related to this change.

@aplanas aplanas requested a review from dwoz Dec 9, 2019
dwoz
dwoz approved these changes Dec 9, 2019
@dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 1, 2020

The windows tests passed but the build is reporting as a failure, this is a known issue we are working on fixing. I'm going to merge this:

OK (total=9295, skipped=1213, passed=8082, failures=0, errors=0)

@dwoz dwoz merged commit e9d75b9 into saltstack:master Jan 1, 2020
48 of 49 checks passed
@waynew waynew added this to PR needs merge to master in PRs to port to master via automation Feb 3, 2020
@waynew waynew moved this from PR needs merge to master to PR merged in PRs to port to master Feb 3, 2020
@aplanas aplanas deleted the backport_51704 branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants