Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using password hashes with MariaDB #55655

Merged
merged 1 commit into from Dec 16, 2019
Merged

Conversation

SMillerDev
Copy link
Contributor

@SMillerDev SMillerDev commented Dec 16, 2019

I rebased PR #54343 since that was all that was needed @dwoz

MariaDB 10.2.0 introduced the 'ALTER USER' statement, but it did NOT remove the need to denote password hashes with the PASSWORD keyword.
Both CREATE USER as well as ALTER USER still need IDENTIFIED BY PASSWORD

This should be a more complete fix compared to previous attempts in #53861 and #54299

What does this PR do?

Fix MariaDB user interactions.

What issues does this PR fix or reference?

#53861 and #54299 and #54343

Previous Behavior

Using password hashes as passwords

New Behavior

Doing what it's told

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

MariaDB always needs the 'PASSWORD' keyword when working with
password hashes, also when ALTER USER is being used.
@SMillerDev SMillerDev requested a review from as a code owner Dec 16, 2019
@ghost ghost requested a review from Ch3LL Dec 16, 2019
dwoz
dwoz approved these changes Dec 16, 2019
@dwoz dwoz merged commit b0fb791 into saltstack:master Dec 16, 2019
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants