Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engine for fluent to master #55711

Merged
merged 6 commits into from Jan 4, 2020
Merged

Conversation

mchugh19
Copy link
Contributor

@mchugh19 mchugh19 commented Dec 20, 2019

What does this PR do?

Master port of #51942
Adds new engine to export events to fluentd

What issues does this PR fix or reference?

None

Tests written?

No - as discussed in PR #51942...

Having a bit of trouble here. The other engine test examples are the sqs engine which validates sqs messages can be resent on the salt event bus, while the slack tests validate the complex configuration. For the fluent engine, it really is just:

while True:
    salt_event = event_bus.get_event_block()
    if salt_event:
        event.Event(app, salt_event)

where I'm struggling to come up with a meaningful test. As long as the fluent event module is functional, and the event_bus.get_event_block() works as expected, there isn't much else to validate here.

Commits signed with GPG?

No

@mchugh19 mchugh19 requested a review from as a code owner Dec 20, 2019
@ghost ghost requested a review from dwoz Dec 20, 2019
@mchugh19 mchugh19 mentioned this pull request Dec 20, 2019
@dwoz
Copy link
Contributor

@dwoz dwoz commented Dec 26, 2019

@mchugh19 Can you please rebase to the current head of master and resolve the change log conflicts?

@mchugh19
Copy link
Contributor Author

@mchugh19 mchugh19 commented Dec 27, 2019

Resolved conflicts on release notes

@dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 1, 2020

@mchugh19 Please have a look at the docs failure.

@mchugh19
Copy link
Contributor Author

@mchugh19 mchugh19 commented Jan 2, 2020

@dwoz docs should be better. Go go jenkins doc build

@dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 4, 2020

re-run full centos

dwoz
dwoz approved these changes Jan 4, 2020
@dwoz dwoz merged commit d0fd3e2 into saltstack:master Jan 4, 2020
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants