Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ES index get_settings and put_settings methods #55721

Merged
merged 1 commit into from Dec 23, 2019

Conversation

Oloremo
Copy link
Contributor

@Oloremo Oloremo commented Dec 21, 2019

What does this PR do?

Added two Elasticsearch API methods:
put_settings
get_settings

To the Salt Elasticsearch module

What issues does this PR fix or reference?

#53736

Previous Behavior

These methods were not supported

New Behavior

These methods now supported

Tests written?

Yes

Commits signed with GPG?

Yes

@Oloremo Oloremo requested a review from as a code owner Dec 21, 2019
@ghost ghost requested a review from garethgreenaway Dec 21, 2019
@Oloremo Oloremo force-pushed the 53736-added-es-index-settings branch 4 times, most recently from 6f1c839 to 742f33b Compare Dec 21, 2019
@@ -28,7 +28,8 @@ Versions are `MAJOR.PATCH`.

### Added

- [#54917](https://github.com/saltstack/salt/pull/54917) - Added get_settings, put_settings and flush_synced methods for Elasticsearch module. - [@Oloremo](https://github.com/Oloremo)
- [#54505](https://github.com/saltstack/salt/issues/54505) - Added cluster get_settings, put_settings and flush_synced methods for Elasticsearch module. - [@Oloremo](https://github.com/Oloremo)
Copy link
Contributor Author

@Oloremo Oloremo Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it a bit to show that it was about cluster settings

@Oloremo Oloremo force-pushed the 53736-added-es-index-settings branch from 742f33b to 6c5287a Compare Dec 21, 2019
@Oloremo Oloremo force-pushed the 53736-added-es-index-settings branch from 6c5287a to 48b5b7e Compare Dec 21, 2019
@Oloremo
Copy link
Contributor Author

@Oloremo Oloremo commented Dec 22, 2019

re-run full centos7-py2
re-run full centos7-py3
re-run full centos7-py2-tornado

dwoz
dwoz approved these changes Dec 23, 2019
@dwoz dwoz merged commit 625deac into saltstack:master Dec 23, 2019
49 checks passed
@Oloremo Oloremo deleted the 53736-added-es-index-settings branch Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants