Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the osfullname grain on FreeBSD #55751

Merged
merged 6 commits into from
Jan 9, 2020
Merged

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Dec 28, 2019

What does this PR do?

Sets the osfullname to "FreeBSD" on FreeBSD

What issues does this PR fix or reference?

none

Previous Behavior

grains.get osfullname would return nothing

New Behavior

grains.get osfullname will return "FreeBSD"

Tests written?

No. The existing TestModulesGrains.test_get_core_grains test will now pass on FreeBSD

Commits signed with GPG?

Yes

@asomers asomers requested a review from a team as a code owner December 28, 2019 16:07
@ghost ghost requested a review from Ch3LL December 28, 2019 16:07
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You for your contribution!

Could you please add a small unittest around this change?

@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jan 2, 2020
@garethgreenaway garethgreenaway removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jan 6, 2020
@asomers
Copy link
Contributor Author

asomers commented Jan 8, 2020

@s0undt3ch are we good here? The test failure looks unrelated.

@dwoz dwoz merged commit 02ee2c1 into saltstack:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants