Set the osfullname grain on FreeBSD #55751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
s0undt3ch
suggested changes
Jan 1, 2020
Collaborator
s0undt3ch
left a comment
s0undt3ch
left a comment
There was a problem hiding this comment.
Thank You for your contribution!
Could you please add a small unittest around this change?
dwoz
added
the
needs-testcase
garethgreenaway
removed
the
needs-testcase
Contributor
Author
|
@s0undt3ch are we good here? The test failure looks unrelated. |
s0undt3ch
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets the osfullname to "FreeBSD" on FreeBSD
What issues does this PR fix or reference?
none
Previous Behavior
grains.get osfullnamewould return nothingNew Behavior
grains.get osfullnamewill return "FreeBSD"Tests written?
No. The existing TestModulesGrains.test_get_core_grains test will now pass on FreeBSD
Commits signed with GPG?
Yes