Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rabbitmq additions master #55767

Merged
merged 11 commits into from Jan 2, 2020
Merged

Conversation

github-abcde
Copy link
Contributor

@github-abcde github-abcde commented Dec 31, 2019

Master port of #53123

What does this PR do?

It adds states (in states/rabbitmq_upstream.py and functions (in modules/rabbitmq.py) to manipulate rabbitMQ upstream definitions.

What issues does this PR fix or reference?

None that I'm aware of

Previous Behavior

Unable to add/remove/modify rabbitMQ upstreams.

New Behavior

RabbitMQ upstream definitions can be made _present or _absent or manipulated via execution functions.

Tests written?

Yes

Commits signed with GPG?

Yes

github-abcde added 11 commits Dec 31, 2019
Pylint-inspired layout changes.
Also remove empty lines in _safe_output function.
…t. Renamed dicttrim.remove_empty_values to data.filter_falsey as per PR 52499.
…tion"-parameter to using all the parameters that make up the definition.
Refactored upstream_present to remove duplicate code.
…et_upstream, delete_upstream. Pylint-inspired fixes.
Fixed docstring for salt/states/rabbitmq_upstream.py:present
@github-abcde github-abcde requested a review from as a code owner Dec 31, 2019
@ghost ghost requested a review from garethgreenaway Dec 31, 2019
dwoz
dwoz approved these changes Jan 2, 2020
@dwoz dwoz merged commit 3380ad5 into saltstack:master Jan 2, 2020
49 checks passed
@github-abcde github-abcde deleted the rabbitmq_additions-master branch Jan 3, 2020
@github-abcde github-abcde mentioned this pull request Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants