salt.renderers.gpg: Cache GPG data if gpg_cache=True #55772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
sathieu
force-pushed
the
gpg_perfs
branch
2 times, most recently
from
521bde1 to
08274c3
Compare
sathieu
changed the title
sathieu
changed the title
|
@dwoz I've removed the Use Python bindings when available, the most usefull feature being |
|
@dwoz Please review again, the failing tests are not related to this PR. |
Akm0d
approved these changes
May 14, 2020
sagetherage
added
master-port
ZRelease-Sodium
3 tasks
sathieu
added a commit
to sathieu/salt
that referenced
this pull request
Jul 9, 2020
dwoz
pushed a commit
that referenced
this pull request
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
NB :
pillar_cachedoesn't work reliably as it can return obsolete data.What issues does this PR fix or reference?
Previous Behavior
Doing
salt <matcher> pillar.itemsmatching 60 minions with several pillars encrypted, we got timeout error after 45s.New Behavior
The same command returns within 2 to 4 seconds.
Tests written?
Yes
Commits signed with GPG?
No