Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Porting #50261 to master - beacons #55794

Merged
merged 80 commits into from Jan 21, 2020

Conversation

garethgreenaway
Copy link
Member

@garethgreenaway garethgreenaway commented Jan 6, 2020

What does this PR do?

Porting #50261 to master

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from as a code owner Jan 6, 2020
@ghost ghost requested a review from dwoz Jan 6, 2020
@dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 7, 2020

@garethgreenaway Test failures seem to be valid.

@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Jan 7, 2020

Could you please also backport the multi-engine PR? #50059

@garethgreenaway
Copy link
Member Author

@garethgreenaway garethgreenaway commented Jan 9, 2020

@max-arnold thanks. I'll get that one ported over as well.

@garethgreenaway garethgreenaway changed the title [master] Porting #50261 to master [master] Porting #50261 to master - beacons Jan 17, 2020
dwoz and others added 23 commits Jan 17, 2020
…_environment_variables_for_releases

set release versions with environment variables in the docs
Remove references to `include_default`
@codecov
Copy link

@codecov codecov bot commented Jan 19, 2020

Codecov Report

No coverage uploaded for pull request base (master@3140dbe). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55794   +/-   ##
=========================================
  Coverage          ?   16.99%           
=========================================
  Files             ?     1202           
  Lines             ?   224685           
  Branches          ?    49269           
=========================================
  Hits              ?    38172           
  Misses            ?   183757           
  Partials          ?     2756
Flag Coverage Δ
#archlts 16.25% <0%> (?)
#centos7 23.76% <0%> (?)
#proxy 23.79% <0%> (?)
#py2 16.84% <0%> (?)
#py3 16.69% <0%> (?)
#runtests 16.99% <0%> (?)
#ubuntu1604 23.73% <0%> (?)
#zeromq 16.99% <0%> (?)
Impacted Files Coverage Δ
salt/modules/beacons.py 7.29% <0%> (ø)
salt/beacons/__init__.py 13.74% <0%> (ø)

1 similar comment
@codecov
Copy link

@codecov codecov bot commented Jan 19, 2020

Codecov Report

No coverage uploaded for pull request base (master@3140dbe). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55794   +/-   ##
=========================================
  Coverage          ?   16.99%           
=========================================
  Files             ?     1202           
  Lines             ?   224685           
  Branches          ?    49269           
=========================================
  Hits              ?    38172           
  Misses            ?   183757           
  Partials          ?     2756
Flag Coverage Δ
#archlts 16.25% <0%> (?)
#centos7 23.76% <0%> (?)
#proxy 23.79% <0%> (?)
#py2 16.84% <0%> (?)
#py3 16.69% <0%> (?)
#runtests 16.99% <0%> (?)
#ubuntu1604 23.73% <0%> (?)
#zeromq 16.99% <0%> (?)
Impacted Files Coverage Δ
salt/modules/beacons.py 7.29% <0%> (ø)
salt/beacons/__init__.py 13.74% <0%> (ø)

…mes.BadTestModuleNamesTestCase.test_module_name_source_match failure.
dwoz
dwoz approved these changes Jan 21, 2020
@dwoz dwoz merged commit 7f384df into saltstack:master Jan 21, 2020
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants