Restrict the 'start_event_grains' only to the start events#55885
Merged
dwoz merged 2 commits intosaltstack:masterfrom Jan 21, 2020
Merged
Restrict the 'start_event_grains' only to the start events#55885dwoz merged 2 commits intosaltstack:masterfrom
dwoz merged 2 commits intosaltstack:masterfrom
Conversation
ghost
requested a review
from 
Contributor
Author
|
Thank you @max-arnold for noticing it. It would be nice if you could test it as well. |
Ch3LL
suggested changes
Jan 16, 2020
Ch3LL
approved these changes
Jan 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#54948 introduced an unintended effect where
start_event_grainswere being passed to events other than start event, which wasn't the idea. This PR restrict these grains to startup events.What issues does this PR fix or reference?
#55870
Previous Behavior
Grains defined against
start_event_grainswere being passed to events other that start events.New Behavior
Grains defined against
start_event_grainsare being passed to only start eventsTests written?
The existing test has been modified
Yes
Commits signed with GPG?
No