Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the 'start_event_grains' only to the start events #55885

Merged
merged 2 commits into from Jan 21, 2020

Conversation

admd
Copy link
Contributor

@admd admd commented Jan 16, 2020

What does this PR do?

#54948 introduced an unintended effect where start_event_grains were being passed to events other than start event, which wasn't the idea. This PR restrict these grains to startup events.

What issues does this PR fix or reference?

#55870

Previous Behavior

Grains defined against start_event_grains were being passed to events other that start events.

New Behavior

Grains defined against start_event_grains are being passed to only start events

Tests written?

The existing test has been modified

Yes

Commits signed with GPG?

No

@admd admd requested a review from as a code owner Jan 16, 2020
@ghost ghost requested a review from DmitryKuzmenko Jan 16, 2020
@admd
Copy link
Contributor Author

@admd admd commented Jan 16, 2020

Thank you @max-arnold for noticing it. It would be nice if you could test it as well.
cc @waynew

@Ch3LL Ch3LL added the ZRELEASED - Neon label Jan 16, 2020
tests/unit/test_minion.py Show resolved Hide resolved
Ch3LL
Ch3LL approved these changes Jan 16, 2020
@dwoz dwoz merged commit 762fdde into saltstack:master Jan 21, 2020
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRELEASED - Neon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants