Return only targeted minion in cache.pillar runner when using tgt #55908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
waynew
approved these changes
Jan 21, 2020
cmcmarrow
approved these changes
Jan 22, 2020
s0undt3ch
approved these changes
Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Only return cached pillar data for minion that is passed with
tgt.What issues does this PR fix or reference?
Fixes #53039
Previous Behavior
If you run
salt-run --out=json cache.pillar tgt='doesnotexist'with a target that does not exist it still returns all the cached pilllar data for ALL minions.New Behavior
If you run
salt-run --out=json cache.pillar tgt='doesnotexist'with a target that does not exist will not return anything.Also as you can see I updated the docs to state:
If tgt is not set will return cached pillars for all minions.The reason I did this is this is the current behavior that a user can runcache.pillarwithout a tgt set and all pillar data would be returned,and the other reason istgtis an not required as its currently a kwarg. For these reasons I kept this behavior as its expected. If we want to eventually require thetgtargument for some reason then we would need to set it on a deprecation path, but I believe this change is best path for now.Tests written?
Yes
Commits signed with GPG?
Yes