Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tornado 4.5.3 codebase to salt/ext #55927

Merged
merged 4 commits into from Jan 23, 2020
Merged

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 21, 2020

What does this PR do?

Adds tornado 4.5.3 codebase to salt/ext

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from as a code owner Jan 21, 2020
@ghost ghost requested a review from garethgreenaway Jan 21, 2020
waynew
waynew approved these changes Jan 21, 2020
@dwoz
Copy link
Contributor Author

@dwoz dwoz commented Jan 22, 2020

re-run full all

@dwoz dwoz merged commit 9b74e9b into saltstack:master Jan 23, 2020
49 checks passed
@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Jan 30, 2020

Maybe it makes sense to review distro-specific tornado patches, to see if it is necessary to include some of them. For example, Ubuntu Bionic applies 9 patches on top of Tornado 4.5.3. One of these patches (sockopt.patch) may or may not be relevant.

https://packages.ubuntu.com/bionic/python-tornado
tornadoweb/tornado#2536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants