Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vendor tornado instead of system tornado #55952

Merged
merged 8 commits into from Jan 25, 2020
Merged

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 23, 2020

Tests written?

Yes

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from as a code owner Jan 23, 2020
@ghost ghost requested a review from DmitryKuzmenko Jan 23, 2020
waynew
waynew approved these changes Jan 23, 2020
tests/integration/__init__.py Outdated Show resolved Hide resolved
tests/integration/__init__.py Outdated Show resolved Hide resolved
salt/utils/http.py Show resolved Hide resolved
Akm0d
Akm0d approved these changes Jan 23, 2020
tests/unit/test_vendor_tornado.py Outdated Show resolved Hide resolved
salt/transport/zeromq.py Outdated Show resolved Hide resolved
@dwoz dwoz requested a review from garethgreenaway Jan 24, 2020
Copy link
Contributor

@Ch3LL Ch3LL left a comment

also would be good to add note of this change in the changelog/release notes

salt/transport/client.py Outdated Show resolved Hide resolved
salt/utils/zeromq.py Outdated Show resolved Hide resolved
@dwoz dwoz requested a review from Ch3LL Jan 24, 2020
Copy link
Contributor

@Ch3LL Ch3LL left a comment

can we get a note added to the changelog/release notes about this change?

@dwoz
Copy link
Contributor Author

@dwoz dwoz commented Jan 24, 2020

can we get a note added to the changelog/release notes about this change?

Yes, I have one more pull request to make for this change too update the dependencies. I will add the release notes to the next PR.

Ch3LL
Ch3LL approved these changes Jan 24, 2020
@dwoz dwoz merged commit 192edbf into saltstack:master Jan 25, 2020
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants