Use vendor tornado instead of system tornado#55952
Merged
dwoz merged 8 commits intosaltstack:masterfrom Jan 25, 2020
Merged
Conversation
ghost
requested a review
from 
waynew
approved these changes
Jan 23, 2020
twangboy
approved these changes
Jan 23, 2020
Akm0d
reviewed
Jan 23, 2020
Akm0d
reviewed
Jan 23, 2020
Akm0d
reviewed
Jan 23, 2020
Akm0d
approved these changes
Jan 23, 2020
garethgreenaway
suggested changes
Jan 23, 2020
garethgreenaway
approved these changes
Jan 24, 2020
Ch3LL
suggested changes
Jan 24, 2020
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
also would be good to add note of this change in the changelog/release notes
dwoz
force-pushed
the
vendored_tornado2
branch
from
e7415c7 to
108b53c
Compare
dwoz
force-pushed
the
vendored_tornado2
branch
from
108b53c to
a85317f
Compare
Ch3LL
suggested changes
Jan 24, 2020
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
can we get a note added to the changelog/release notes about this change?
Contributor
Author
Yes, I have one more pull request to make for this change too update the dependencies. I will add the release notes to the next PR. |
Ch3LL
approved these changes
Jan 24, 2020
s0undt3ch
approved these changes
Jan 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests written?
Yes
Commits signed with GPG?
Yes