Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vendor tornado instead of system tornado #55952

Merged
merged 8 commits into from
Jan 25, 2020
Merged

Use vendor tornado instead of system tornado #55952

merged 8 commits into from
Jan 25, 2020

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 23, 2020

Tests written?

Yes

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from a team as a code owner January 23, 2020 23:12
@ghost ghost requested a review from DmitryKuzmenko January 23, 2020 23:12
garethgreenaway
garethgreenaway suggested changes Jan 23, 2020
View reviewed changes
tests/unit/test_vendor_tornado.py Outdated Show resolved Hide resolved
salt/transport/zeromq.py Outdated Show resolved Hide resolved
@dwoz dwoz requested a review from garethgreenaway January 24, 2020 01:14
Ch3LL
Ch3LL suggested changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also would be good to add note of this change in the changelog/release notes

salt/transport/client.py Outdated Show resolved Hide resolved
salt/utils/zeromq.py Outdated Show resolved Hide resolved
@dwoz dwoz force-pushed the vendored_tornado2 branch from e7415c7 to 108b53c Compare January 24, 2020 19:08
@dwoz dwoz force-pushed the vendored_tornado2 branch from 108b53c to a85317f Compare January 24, 2020 19:12
@dwoz dwoz requested a review from Ch3LL January 24, 2020 19:12
Ch3LL
Ch3LL suggested changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get a note added to the changelog/release notes about this change?

@dwoz
Copy link
Contributor Author

dwoz commented Jan 24, 2020

can we get a note added to the changelog/release notes about this change?

Yes, I have one more pull request to make for this change too update the dependencies. I will add the release notes to the next PR.

@s0undt3ch s0undt3ch mentioned this pull request Jan 25, 2020
Closed
@dwoz dwoz merged commit 192edbf into saltstack:master Jan 25, 2020
@dwoz dwoz mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

@Akm0d Akm0d Akm0d approved these changes

@Ch3LL Ch3LL Ch3LL approved these changes

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@waynew waynew waynew approved these changes

@DmitryKuzmenko DmitryKuzmenko Awaiting requested review from DmitryKuzmenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dwoz @waynew @s0undt3ch @garethgreenaway @Ch3LL @Akm0d @twangboy