-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several bugs in slack_webhook returner #55968
Conversation
@sagetherage Could you please label this for Neon? (this is a bugfix for a new feature that was merged to Neon) |
@cdalvaro Better, but is not quite there yet:
I didn't test this thoroughly, but you can prevent the above traceback by adding the following function: def _state_return(ret):
'''
Return True if ret is a Salt state return
:param ret: The Salt return
'''
ret_data = ret.get('return')
if not isinstance(ret_data, dict):
return False
return ret_data and '__id__' in next(iter(ret_data.values())) And then replacing Also a small usability nitpick. Instead of:
Try this:
This way specifying full webhook URLs would also work:
|
Thank you very much for all your help, @max-arnold I start working on it right now! |
@cdalvaro AFAIK, there is no need to modify the man page. It will be automatically generated before the release. |
778c63a
to
2d85fa0
Compare
2d85fa0
to
bfcbe1b
Compare
I have labeled @max-arnold but it needs to be rebased with Master and it needs to pass the build to get into Neon. |
…bugfix/slack_webhook
…bugfix/slack_webhook
All my tests are passing, but each time I merge the master branch with mine, distinct platforms/environments fail by different reasons. |
@cdalvaro I've restarted the tests that were failing and will monitor them to ensure we can get this merged. |
@garethgreenaway, could you restart tests for ci/py2/centos6, it seems that failing tests are not related with my changes. Thank you in advance! |
test.ping @garethgreenaway |
OMG! All checks have passed! 🎉 |
4d06514
to
e05c508
Compare
What does this PR do?
This PR fixes some issues detected by @max-arnold on #55342
What issues does this PR fix or reference?
Simple states like
test.ping
did not work with this returner.Tests written?
👍
Commits signed with GPG?
👍