Fixed the skip_files_list_verify in archive.extracted state#55975
Fixed the skip_files_list_verify in archive.extracted state#55975dwoz merged 1 commit intosaltstack:masterfrom
Conversation
There was a problem hiding this comment.
I don't like it, but I alternative was to change the approach for this whole caching thing in the state which sounds scary for me. Right now it's a bit magical like this archive cache extrn_files is only exists in a single line in the state and no other states or modules aware of it. So I have to mimic that logic to generate the expected path to the file.
There was a problem hiding this comment.
This is required due to cache limitation. Right now any test with skip_files_list_verify=True and source_hash_update=True will create a hash file in minion cache and other tests will use it when they shouldn't.
The alternative was to pass a different source for each test which sounds worse.
|
re-run full ubuntu1604-py2-m2crypto |
|
re-run full centos7-py2 |
7ad38d7 to
6fa549e
Compare
|
@cmcmarrow Mind to look at it one more time? No changes were made, just rebased to be up to date with the current master. |
|
re-run full fedora32-py3 |
|
re-run full fedora32-py3 |
|
re-run fedora32 |
6fa549e to
a0b5828
Compare
…p_source set to False
a0b5828 to
04c51e9
Compare
What does this PR do?
It fixes the
skip_files_list_verifylogic inarchive.extractedstate for the case ifkeep_sourceis set toFalse.What issues does this PR fix or reference?
#55443
Previous Behavior
Before that this logic only worked if we keep the source which is not how I originally intended to implement this. See #55443
New Behavior
Now, this logic works for both cases of
keep_source, yet there is a bunch of limitations that has to be taken into account.Implementation details
I don't fancy current implementation. There is a lot of magic going on in this state, especially regarding caching.
Also, there is a huge edge case that I highlighted in the warning section of the
skip_files_list_verifyargument. To properly fix that we need to introduce some smart Minion cache controls, see #34369Tests written?
Yes
Commits signed with GPG?
Yes