-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Adding hold and unhold support for mac_brew_pkg. #55978
Merged
dwoz
merged 5 commits into
saltstack:master
from
garethgreenaway:adding_hold_unhold_macbrew
May 21, 2020
Merged
[master] Adding hold and unhold support for mac_brew_pkg. #55978
dwoz
merged 5 commits into
saltstack:master
from
garethgreenaway:adding_hold_unhold_macbrew
May 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from dwoz
January 25, 2020 23:57
Codecov Report
@@ Coverage Diff @@
## master #55978 +/- ##
=========================================
Coverage ? 17.42%
=========================================
Files ? 1234
Lines ? 232402
Branches ? 50699
=========================================
Hits ? 40474
Misses ? 188913
Partials ? 3015
|
re-run docs |
Codecov Report
@@ Coverage Diff @@
## master #55978 +/- ##
=======================================
Coverage 39.35% 39.35%
=======================================
Files 1531 1531
Lines 271545 271545
Branches 57150 57150
=======================================
Hits 106842 106842
Misses 152547 152547
Partials 12156 12156
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #55978 +/- ##
=======================================
Coverage 39.35% 39.35%
=======================================
Files 1531 1531
Lines 271545 271545
Branches 57150 57150
=======================================
Hits 106842 106842
Misses 152547 152547
Partials 12156 12156
|
garethgreenaway
force-pushed
the
adding_hold_unhold_macbrew
branch
from
May 21, 2020 18:30
4fdb5f5
to
01268d4
Compare
dwoz
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding hold and unhold support for mac_brew_pkg.
What issues does this PR fix or reference?
N/A
Tests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.