Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Adding hold and unhold support for mac_brew_pkg. #55978

Merged
merged 5 commits into from
May 21, 2020

Conversation

garethgreenaway
Copy link
Contributor

What does this PR do?

Adding hold and unhold support for mac_brew_pkg.

What issues does this PR fix or reference?

N/A

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner January 25, 2020 23:57
@ghost ghost requested a review from dwoz January 25, 2020 23:57
@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f4ec3df). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55978   +/-   ##
=========================================
  Coverage          ?   17.42%           
=========================================
  Files             ?     1234           
  Lines             ?   232402           
  Branches          ?    50699           
=========================================
  Hits              ?    40474           
  Misses            ?   188913           
  Partials          ?     3015
Flag Coverage Δ
#archlts 16.71% <0%> (?)
#centos7 24.43% <0%> (?)
#proxy 24.46% <0%> (?)
#py2 17.23% <0%> (?)
#py3 17.09% <0%> (?)
#runtests 17.42% <0%> (?)
#ubuntu1604 24.41% <0%> (?)
#zeromq 17.42% <0%> (?)

@garethgreenaway
Copy link
Contributor Author

re-run docs

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #55978 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #55978   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files        1531     1531           
  Lines      271545   271545           
  Branches    57150    57150           
=======================================
  Hits       106842   106842           
  Misses     152547   152547           
  Partials    12156    12156
Flag Coverage Δ
#amazon1 39.35% <0%> (ø) ⬆️
#py2 39.35% <0%> (ø) ⬆️
#runtests 39.35% <0%> (ø) ⬆️
#zeromq 39.35% <0%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #55978 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #55978   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files        1531     1531           
  Lines      271545   271545           
  Branches    57150    57150           
=======================================
  Hits       106842   106842           
  Misses     152547   152547           
  Partials    12156    12156
Flag Coverage Δ
#amazon1 39.35% <0%> (ø) ⬆️
#py2 39.35% <0%> (ø) ⬆️
#runtests 39.35% <0%> (ø) ⬆️
#zeromq 39.35% <0%> (ø) ⬆️

@Ch3LL Ch3LL removed the request for review from a team April 15, 2020 14:27
@dwoz dwoz merged commit 1dc2e70 into saltstack:master May 21, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants