Added support of GRANTS with per column privileges to MYSQL module #55980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from
Closed
|
re-run full debian9-py2 |
|
re-run full ubuntu1604-py2-m2crypto |
|
@sizgiyaev can you address the merge conflict, please? |
|
Merge conflict fixed. |
garethgreenaway
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current MYSQL module can't handle grants with per column defined privileges:
More info: https://dev.mysql.com/doc/refman/8.0/en/grant.html#grant-column-privileges
Previous Behavior
Works:
GRANT SELECT ON database.table TO user@hostDoesn't work:
GRANT SELECT(column1, column2) ON database.table TO user@hostNew Behavior
Works:
GRANT SELECT ON database.table TO user@hostWorks:
GRANT SELECT(column1, column2) ON database.table TO user@hostTests written?
Yes
Commits signed with GPG?
No
The PR is to
masterbranch due to request of @dwoz in previous PR #55946