Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of GRANTS with per column privileges to MYSQL module #55980

Merged
merged 6 commits into from Jul 29, 2020
Merged

Added support of GRANTS with per column privileges to MYSQL module #55980

merged 6 commits into from Jul 29, 2020

Conversation

sizgiyaev
Copy link
Contributor

What does this PR do?

The current MYSQL module can't handle grants with per column defined privileges:
More info: https://dev.mysql.com/doc/refman/8.0/en/grant.html#grant-column-privileges

Previous Behavior

Works: GRANT SELECT ON database.table TO user@host
Doesn't work: GRANT SELECT(column1, column2) ON database.table TO user@host

New Behavior

Works: GRANT SELECT ON database.table TO user@host
Works: GRANT SELECT(column1, column2) ON database.table TO user@host

Tests written?

Yes

Commits signed with GPG?

No

The PR is to master branch due to request of @dwoz in previous PR #55946

@sizgiyaev sizgiyaev requested a review from a team as a code owner January 26, 2020 08:34
@ghost ghost requested a review from garethgreenaway January 26, 2020 08:34
@Akm0d Akm0d added Bug broken, incorrect, or confusing behavior P4 Priority 4 labels Jan 27, 2020
@Akm0d Akm0d added this to In progress in Sodium via automation Jan 27, 2020
@Akm0d Akm0d added this to the Approved milestone Jan 27, 2020
@sizgiyaev
Copy link
Contributor Author

re-run full debian9-py2

@sizgiyaev
Copy link
Contributor Author

re-run full ubuntu1604-py2-m2crypto

@Ch3LL Ch3LL removed the request for review from a team April 15, 2020 14:27
@sagetherage
Copy link
Contributor

@sizgiyaev can you address the merge conflict, please?

@sagetherage sagetherage added the ZRelease-Sodium retired label label May 12, 2020
@garethgreenaway
Copy link
Member

Merge conflict fixed.

@sagetherage sagetherage removed the ZRelease-Sodium retired label label May 26, 2020
@sagetherage sagetherage removed this from In progress in Sodium May 26, 2020
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label May 26, 2020
@sagetherage sagetherage removed the P4 Priority 4 label Jun 3, 2020
@dwoz dwoz merged commit d5aff38 into saltstack:master Jul 29, 2020
26 checks passed
@sagetherage sagetherage added this to Done in Magnesium Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Magnesium Mg release after Na prior to Al
Projects
No open projects
Magnesium
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants