Tornado requirements and change log - #55982
Merged
Merged
Conversation
ghost
requested a review
from Akm0d
January 26, 2020 17:05
Ch3LL
suggested changes
Jan 26, 2020
s0undt3ch
reviewed
Jan 26, 2020
s0undt3ch
left a comment
s0undt3ch
left a comment
Contributor
There was a problem hiding this comment.
I think you should add the tornado requirements to the base.txt file since they are now a hard dependency(they were before but they were pulled from tornado).
And remove tornado from base.txt.
If pkg/win/req.txt or pkg/osx/req.txt doesn't pull from base.txt, we also need to pull out tornado from those and add the tornado dependencies.
Let me know if you need me to update the static requirements after three changes.
dwoz
force-pushed
the
vendored_tornado3
branch
from
January 26, 2020 20:15
8b22b17 to
6ed189e
Compare
s0undt3ch
suggested changes
Jan 26, 2020
Contributor
|
I know our current requirement lock process is bad and broken, I'm looking at either fixing it or getting an alternative post neon. |
s0undt3ch
approved these changes
Jan 26, 2020
Ch3LL
approved these changes
Jan 26, 2020
waynew
approved these changes
Jan 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Tornado requirements and changelog
Tests written?
Yes - In a previous PR
Commits signed with GPG?
Yes.