Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tornado requirements and change log #55982

Merged
merged 4 commits into from Jan 27, 2020
Merged

Tornado requirements and change log #55982

merged 4 commits into from Jan 27, 2020

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Jan 26, 2020

What does this PR do?

Update Tornado requirements and changelog

Tests written?

Yes - In a previous PR

Commits signed with GPG?

Yes.

@dwoz dwoz requested a review from as a code owner Jan 26, 2020
@ghost ghost requested a review from Akm0d Jan 26, 2020
requirements/static/py3.7/windows.txt Outdated Show resolved Hide resolved
Copy link
Member

@s0undt3ch s0undt3ch left a comment

I think you should add the tornado requirements to the base.txt file since they are now a hard dependency(they were before but they were pulled from tornado).
And remove tornado from base.txt.

If pkg/win/req.txt or pkg/osx/req.txt doesn't pull from base.txt, we also need to pull out tornado from those and add the tornado dependencies.

Let me know if you need me to update the static requirements after three changes.

@dwoz dwoz requested review from s0undt3ch and Ch3LL Jan 26, 2020
pkg/osx/req.txt Show resolved Hide resolved
pkg/windows/req.txt Show resolved Hide resolved
@s0undt3ch
Copy link
Member

@s0undt3ch s0undt3ch commented Jan 26, 2020

I know our current requirement lock process is bad and broken, I'm looking at either fixing it or getting an alternative post neon.

@dwoz dwoz requested a review from s0undt3ch Jan 26, 2020
Ch3LL
Ch3LL approved these changes Jan 26, 2020
waynew
waynew approved these changes Jan 27, 2020
@dwoz dwoz merged commit fa2ac50 into saltstack:master Jan 27, 2020
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants