Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tornado 4.5.3 embedded for Python 3.7 support #56019

Merged
merged 1 commit into from Jan 29, 2020

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Jan 29, 2020

What does this PR do?

Adjusts for use of reserved keyword async in Python 3.7
Code change as previously utilized by Debian in Debian 10

What issues does this PR fix or reference?

#56018

Previous Behavior

On Python 3.7, would have errors, for example: Amazon Linux 2 Python 3.7, see associated issue

New Behavior

Code builds and packages cleanly.

Tests written?

Yes, nightly build script for Amazon Linux 2 Python 3 support

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 added the ZRELEASED - Neon label Jan 29, 2020
@dmurphy18 dmurphy18 requested a review from as a code owner Jan 29, 2020
@ghost ghost requested a review from xeacott Jan 29, 2020
waynew
waynew approved these changes Jan 29, 2020
@waynew waynew added this to In Progress in Neon via automation Jan 29, 2020
Akm0d
Akm0d approved these changes Jan 29, 2020
@dwoz dwoz merged commit 0f12432 into saltstack:master Jan 29, 2020
34 of 49 checks passed
Neon automation moved this from In Progress to Done Jan 29, 2020
@dmurphy18 dmurphy18 deleted the fix_tornado_async37 branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRELEASED - Neon
Projects
No open projects
Neon
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants