Fix Tornado 4.5.3 embedded for Python 3.7 support #56019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
waynew
approved these changes
Jan 29, 2020
Akm0d
approved these changes
Jan 29, 2020
twangboy
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adjusts for use of reserved keyword async in Python 3.7
Code change as previously utilized by Debian in Debian 10
What issues does this PR fix or reference?
#56018
Previous Behavior
On Python 3.7, would have errors, for example: Amazon Linux 2 Python 3.7, see associated issue
New Behavior
Code builds and packages cleanly.
Tests written?
Yes, nightly build script for Amazon Linux 2 Python 3 support
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.