Replace pycryptodome with pycrypto #56039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
s0undt3ch
force-pushed
the
hotfix/setuptools
branch
from
e2d3b8a to
84ada8c
Compare
dmurphy18
reviewed
Jan 31, 2020
Contributor
dmurphy18
left a comment
dmurphy18
left a comment
There was a problem hiding this comment.
Wondering about the backports_abc in Py3 files since isn't this a Python 2.7 thing, see example: https://github.com/saltstack/salt/pull/56039/files#diff-4b7ce34caa7ceeb596ff14c8a261f9b2
Contributor
Author
|
That should get fixed once @dwoz 's PR get's merged since i'll have to regenerate static requirements |
Akm0d
approved these changes
Jan 31, 2020
Due to issues found during package testing for the several supported linux distributions, we're switching back our crypto depencency to pycrypto. Security concerned users are still advised to install the latest m2crypto or pycryptodome library after pip installing salt since salt is prepared to work with whatever is available.
s0undt3ch
force-pushed
the
hotfix/setuptools
branch
from
84ada8c to
69a3d33
Compare
waynew
approved these changes
Jan 31, 2020
dmurphy18
approved these changes
Jan 31, 2020
cmcmarrow
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Due to issues found during package testing for the several supported
linux distributions, we're switching back our crypto depencency to
pycrypto.
Security concerned users are still advised to install the latest m2crypto
or pycryptodome library after pip installing salt since salt is prepared
to work with whatever is available.