Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pycryptodome with pycrypto #56039

Merged
merged 2 commits into from Feb 1, 2020
Merged

Conversation

s0undt3ch
Copy link
Member

@s0undt3ch s0undt3ch commented Jan 31, 2020

What does this PR do?

Due to issues found during package testing for the several supported
linux distributions, we're switching back our crypto depencency to
pycrypto.

Security concerned users are still advised to install the latest m2crypto
or pycryptodome library after pip installing salt since salt is prepared
to work with whatever is available.

@s0undt3ch s0undt3ch requested a review from as a code owner Jan 31, 2020
@ghost ghost requested a review from DmitryKuzmenko Jan 31, 2020
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Wondering about the backports_abc in Py3 files since isn't this a Python 2.7 thing, see example: https://github.com/saltstack/salt/pull/56039/files#diff-4b7ce34caa7ceeb596ff14c8a261f9b2

@s0undt3ch
Copy link
Member Author

@s0undt3ch s0undt3ch commented Jan 31, 2020

That should get fixed once @dwoz 's PR get's merged since i'll have to regenerate static requirements

Akm0d
Akm0d approved these changes Jan 31, 2020
Due to issues found during package testing for the several supported
linux distributions, we're switching back our crypto depencency to
pycrypto.

Security concerned users are still advised to install the latest m2crypto
or pycryptodome library after pip installing salt since salt is prepared
to work with whatever is available.
waynew
waynew approved these changes Jan 31, 2020
@saltstack saltstack deleted a comment from codecov bot Jan 31, 2020
@saltstack saltstack deleted a comment from codecov bot Jan 31, 2020
@dwoz dwoz merged commit 8288117 into saltstack:master Feb 1, 2020
26 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants