Fixed trim_output logic in archive.extracted state #56042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Akm0d
added
Needs-Testcase
Oloremo
force-pushed
the
56041-archive-trim-fix
branch
from
cf46160 to
4b2e97f
Compare
Oloremo
force-pushed
the
56041-archive-trim-fix
branch
from
4b2e97f to
fa97f82
Compare
Oloremo
force-pushed
the
56041-archive-trim-fix
branch
from
fa97f82 to
6d82889
Compare
|
@Akm0d Tests added. PR rebased against the master |
dwoz
approved these changes
Apr 29, 2020
dwoz
removed
the
Needs-Testcase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes trim_output logic in archive.extracted state
What issues does this PR fix or reference?
#56041
Previous Behavior
trim_output argument was ignored in some cases
New Behavior
trim_output argument now working as expected
Tests written?
Yes
Commits signed with GPG?
Yes