Skip to content

Conversation

@ArthurREGNARD
Copy link

Signed-off-by: REGNARD areganrd@leni.fr

What does this PR do?

Add some Modules and States to manage Helm.

What issues does this PR fix or reference?

None

Previous Behavior

None

New Behavior

Manage Helm with Modules and States.

Tests written?

Yes

Commits signed with GPG?

Yes

Signed-off-by: REGNARD <areganrd@leni.fr>
@ArthurREGNARD ArthurREGNARD requested a review from a team as a code owner February 6, 2020 17:26
@ghost ghost requested a review from DmitryKuzmenko February 6, 2020 17:26
@ArthurREGNARD ArthurREGNARD changed the title WIP: Add modules and states to manage Helm. WIP: [NEW FEATURE]modules and states to manage Helm. Feb 6, 2020
@ArthurREGNARD ArthurREGNARD changed the title WIP: [NEW FEATURE]modules and states to manage Helm. WIP: [NEW FEATURE] modules and states to manage Helm. Feb 6, 2020
REGNARD added 5 commits February 6, 2020 19:03
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
@ArthurREGNARD ArthurREGNARD changed the title WIP: [NEW FEATURE] modules and states to manage Helm. [NEW FEATURE] modules and states to manage Helm. Feb 7, 2020
REGNARD added 3 commits February 7, 2020 17:09
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
REGNARD added 7 commits February 12, 2020 15:05
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
Signed-off-by: REGNARD <areganrd@leni.fr>
@ArthurREGNARD
Copy link
Author

ArthurREGNARD commented Mar 2, 2020

@DmitryKuzmenko,

Are you interested on this feature ?

@DmitryKuzmenko
Copy link
Contributor

re-run full amazon1-py2
re-run full centos6-py2
re-run full windows2019

@DmitryKuzmenko
Copy link
Contributor

@ArthurREGNARD thank you for contribution.
@saltstack/team-core what do you think?

@ArthurREGNARD
Copy link
Author

re-run full centos6-py2

4 similar comments
@ArthurREGNARD
Copy link
Author

re-run full centos6-py2

@ArthurREGNARD
Copy link
Author

re-run full centos6-py2

@ArthurREGNARD
Copy link
Author

re-run full centos6-py2

@ArthurREGNARD
Copy link
Author

re-run full centos6-py2

@ArthurREGNARD
Copy link
Author

@saltstack/team-core, @DmitryKuzmenko ,

I re-run some times the ci/py2/centos6`, and the result is a probleme of Memory ...

The PR is ready to merge.

DmitryKuzmenko
DmitryKuzmenko previously approved these changes Mar 11, 2020
@DmitryKuzmenko
Copy link
Contributor

I'm approving this and confirming that centos6 failure is not related.

@DmitryKuzmenko DmitryKuzmenko self-assigned this Apr 6, 2020
@dwoz dwoz merged commit 774270b into saltstack:master Apr 18, 2020
terminalmage added a commit to terminalmage/salt that referenced this pull request Apr 18, 2020
saltstack#56081 was merged several hours
ago, breaking the docs checks. This adds the needed RST files to ensure
docs files are created for this new module.
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@brianthelion
Copy link

@ArthurREGNARD How do you set the --kubeconfig for these states? I tried adding it to the kvflags but that didn't seem to work.

@ArthurREGNARD ArthurREGNARD deleted the newfeature-helm-management branch May 14, 2021 08:19
@ArthurREGNARD
Copy link
Author

@ArthurREGNARD How do you set the --kubeconfig for these states? I tried adding it to the kvflags but that didn't seem to work.

You work with Helm version 3.
Have you done something like that ?

helm_release_is_present:
    helm.release_present:
        - name: release_name
        - chart: repo/chart
        - kvflags:
            kubeconfig: "/path/to/kubeconfig/file"

@brianthelion
Copy link

brianthelion commented May 14, 2021

@ArthurREGNARD Yes, I think the problem is that --kubeconfig needs to go before install like so:

helm  \
  --kubeconfig=/path/to/kubeconfig \
  install \
  ....

whereas the source code puts all the kvflags at the end of the args list.

snelzing pushed a commit to salt-extensions/saltext-helm that referenced this pull request Dec 17, 2023
saltstack/salt#56081 was merged several hours
ago, breaking the docs checks. This adds the needed RST files to ensure
docs files are created for this new module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ZRelease-Sodium retired label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants