Adding nftables functionality for use in EL8 #56259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
Ch3LL
requested changes
Feb 27, 2020
garethgreenaway
previously approved these changes
Mar 5, 2020
Ch3LL
requested changes
Aug 5, 2020
|
@Ch3LL requested changes addressed along with new tests that slid in. I can haz review? |
|
looks like just pre-commit tests that are failing that need to be fixed up. |
|
I think that should fix it |
|
@Ch3LL , it's not immediately obvious to me why lint is failing. |
|
@nicholasmhughes go ahead and rebase and they should no longer fail. There was a linter fail on the head of master that should be fixed by now. |
Ch3LL
approved these changes
Aug 17, 2020
|
@garethgreenaway can we get your re-review here as well |
garethgreenaway
approved these changes
Aug 26, 2020
gqlo
pushed a commit
to gqlo/salt
that referenced
this pull request
Aug 29, 2020
* adding nftables functionality for use in EL8 * default to current functionality * updates for black * updates for black * updates for black * Update test_nftables.py * updates for black * updates for black * updates for black * updates for black * updates for black * updates for black * fix spacing for test comment returns to match state * changed versionadded, black, and lint due to time-travelling PR * fixing test lint failure * more lint fixes Co-authored-by: Sage the Rage <36676171+sagetherage@users.noreply.github.com>
gqlo
pushed a commit
to gqlo/salt
that referenced
this pull request
Sep 1, 2020
* adding nftables functionality for use in EL8 * default to current functionality * updates for black * updates for black * updates for black * Update test_nftables.py * updates for black * updates for black * updates for black * updates for black * updates for black * updates for black * fix spacing for test comment returns to match state * changed versionadded, black, and lint due to time-travelling PR * fixing test lint failure * more lint fixes Co-authored-by: Sage the Rage <36676171+sagetherage@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this PR do?
This PR is the result of attempting to manage nftables on CentOS 8 in a similar fashion to what I had been doing with iptables on previous versions.
What issues does this PR fix or reference?
N/A
Previous Behavior
There were some gaps in functionality for current versions of nftables.
New Behavior
The nftables execution and state modules are now much closer to the iptables modules and work on nftables versions tested with CentOS 8.
Tests written?
Yes
Commits signed with GPG?
Yes