Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nftables functionality for use in EL8 #56259

Merged
merged 22 commits into from Aug 27, 2020

Conversation

nicholasmhughes
Copy link
Collaborator

What does this PR do?

This PR is the result of attempting to manage nftables on CentOS 8 in a similar fashion to what I had been doing with iptables on previous versions.

What issues does this PR fix or reference?

N/A

Previous Behavior

There were some gaps in functionality for current versions of nftables.

New Behavior

The nftables execution and state modules are now much closer to the iptables modules and work on nftables versions tested with CentOS 8.

Tests written?

Yes

Commits signed with GPG?

Yes

@nicholasmhughes nicholasmhughes requested a review from a team as a code owner February 27, 2020 04:07
@ghost ghost requested a review from Ch3LL February 27, 2020 04:07
salt/states/nftables.py Outdated Show resolved Hide resolved
@garethgreenaway garethgreenaway self-assigned this Mar 3, 2020
garethgreenaway
garethgreenaway previously approved these changes Mar 5, 2020
@waynew waynew added this to To do in Core Open PRs Mar 18, 2020
Core Open PRs automation moved this from Assigned to In progress Apr 15, 2020
salt/modules/nftables.py Outdated Show resolved Hide resolved
salt/modules/nftables.py Outdated Show resolved Hide resolved
salt/modules/nftables.py Outdated Show resolved Hide resolved
salt/modules/nftables.py Outdated Show resolved Hide resolved
salt/states/nftables.py Outdated Show resolved Hide resolved
salt/states/nftables.py Outdated Show resolved Hide resolved
salt/states/nftables.py Outdated Show resolved Hide resolved
salt/states/nftables.py Outdated Show resolved Hide resolved
salt/states/nftables.py Outdated Show resolved Hide resolved
@nicholasmhughes
Copy link
Collaborator Author

@Ch3LL requested changes addressed along with new tests that slid in. I can haz review?

@Ch3LL
Copy link
Contributor

Ch3LL commented Aug 7, 2020

looks like just pre-commit tests that are failing that need to be fixed up.

@nicholasmhughes
Copy link
Collaborator Author

I think that should fix it

@nicholasmhughes
Copy link
Collaborator Author

@Ch3LL , it's not immediately obvious to me why lint is failing.

@Ch3LL
Copy link
Contributor

Ch3LL commented Aug 17, 2020

@nicholasmhughes go ahead and rebase and they should no longer fail. There was a linter fail on the head of master that should be fixed by now.

Ch3LL
Ch3LL approved these changes Aug 17, 2020
@Ch3LL
Copy link
Contributor

Ch3LL commented Aug 17, 2020

@garethgreenaway can we get your re-review here as well

@dwoz dwoz merged commit 4fef467 into saltstack:master Aug 27, 2020
27 checks passed
gqlo pushed a commit to gqlo/salt that referenced this pull request Aug 29, 2020
* adding nftables functionality for use in EL8

* default to current functionality

* updates for black

* updates for black

* updates for black

* Update test_nftables.py

* updates for black

* updates for black

* updates for black

* updates for black

* updates for black

* updates for black

* fix spacing for test comment returns to match state

* changed versionadded, black, and lint due to time-travelling PR

* fixing test lint failure

* more lint fixes

Co-authored-by: Sage the Rage <36676171+sagetherage@users.noreply.github.com>
gqlo pushed a commit to gqlo/salt that referenced this pull request Sep 1, 2020
* adding nftables functionality for use in EL8

* default to current functionality

* updates for black

* updates for black

* updates for black

* Update test_nftables.py

* updates for black

* updates for black

* updates for black

* updates for black

* updates for black

* updates for black

* fix spacing for test comment returns to match state

* changed versionadded, black, and lint due to time-travelling PR

* fixing test lint failure

* more lint fixes

Co-authored-by: Sage the Rage <36676171+sagetherage@users.noreply.github.com>
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants