Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add salt-api log file to log rotation #56274

Merged
merged 3 commits into from
Apr 12, 2020

Conversation

mpascual
Copy link

What does this PR do?

Add salt-api log file to salt-common.logrotate

What issues does this PR fix or reference?

No tickets/issues that i've found.

Previous Behavior

salt-api log file is not being rotated

New Behavior

salt-api log file will now be rotated just like the rest of the salt log files.

Tests written?

No tests written.

Commits signed with GPG?

No

@mpascual mpascual requested a review from a team as a code owner February 28, 2020 18:28
@ghost ghost requested a review from twangboy February 28, 2020 18:28
@dmurphy18 dmurphy18 requested a review from Ch3LL March 23, 2020 22:26
@dmurphy18
Copy link
Contributor

@Ch3LL Needs a 3rd review, no tests but changes are correct.

@Ch3LL
Copy link
Contributor

Ch3LL commented Mar 30, 2020

@dmurphy18 im not familiar with this part of the code, is salt-api apart of the salt-common package? Maybe this does not matter.

@dmurphy18
Copy link
Contributor

It is part of the package and it does matter.

I have an issue for the salt-syndic log rotation and was going to fix up the salt-api at that time too, but this PR came in. It looks good to me and the syndic fix will be similar

@dwoz dwoz merged commit 212b188 into saltstack:master Apr 12, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants