Add salt-api log file to log rotation - #56274
Merged
Merged
Conversation
ghost
requested a review
from twangboy
February 28, 2020 18:28
twangboy
approved these changes
Mar 5, 2020
dmurphy18
approved these changes
Mar 23, 2020
Contributor
|
@Ch3LL Needs a 3rd review, no tests but changes are correct. |
Contributor
|
@dmurphy18 im not familiar with this part of the code, is salt-api apart of the salt-common package? Maybe this does not matter. |
Contributor
|
It is part of the package and it does matter. I have an issue for the salt-syndic log rotation and was going to fix up the salt-api at that time too, but this PR came in. It looks good to me and the syndic fix will be similar |
Ch3LL
approved these changes
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add salt-api log file to salt-common.logrotate
What issues does this PR fix or reference?
No tickets/issues that i've found.
Previous Behavior
salt-api log file is not being rotated
New Behavior
salt-api log file will now be rotated just like the rest of the salt log files.
Tests written?
No tests written.
Commits signed with GPG?
No