Add "default" argument to vault.read_secret, vault.list_secrets#56311
Merged
dwoz merged 6 commits intosaltstack:masterfrom May 10, 2020
Merged
Add "default" argument to vault.read_secret, vault.list_secrets#56311dwoz merged 6 commits intosaltstack:masterfrom
dwoz merged 6 commits intosaltstack:masterfrom
Conversation
ghost
requested a review
from 
Contributor
Author
|
@saltstack/team-core Please let me know if I should alter the |
twangboy
previously approved these changes
Mar 5, 2020
dmurphy18
previously approved these changes
Mar 23, 2020
terminalmage
force-pushed
the
vault-exception-handling
branch
from
379ea2c to
e54dd66
Compare
Contributor
|
@terminalmage Can you fix the file conflicts. |
terminalmage
force-pushed
the
vault-exception-handling
branch
from
ad319a8 to
32e7aa9
Compare
Contributor
Author
|
Done. Note that I used version 3001 in versionchanged, let me know if this needs to be modified. |
terminalmage
force-pushed
the
vault-exception-handling
branch
from
32e7aa9 to
99f3302
Compare
terminalmage
force-pushed
the
vault-exception-handling
branch
3 times, most recently
from
dd1960b to
92575ad
Compare
terminalmage
force-pushed
the
vault-exception-handling
branch
from
92575ad to
8932ff8
Compare
dwoz
approved these changes
May 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #46829 (comment)