-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of Windows msi installer related function #56352
Conversation
@twangboy could you please pick up and review? |
ping @markuskramerIgitt looks like there is a conflict here that needs to be resolved. im guessing this conflict occurred with migrating to using the black tool in this PR addition: #55765 |
Thank you @Ch3LL |
Why does the ci/pre-commit check fails? |
@markuskramerIgitt we are using
After this pre-commit would run automatically on commit or you can run it manually for your changes using
|
Thank you @DmitryKuzmenko |
@twangboy Does this look good to you now? |
@dwoz Yeah, looks good. |
What does this PR do?
Tests written?
No, only code removed.