Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systempath grain #56370

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Add systempath grain #56370

merged 3 commits into from
Apr 13, 2020

Conversation

terminalmage
Copy link
Contributor

This provides a grain like pythonpath, only for the system path. In
other words, it's the value of the PATH environment variable, only
formatted as a list of directories.

Resolves #49049.

@terminalmage terminalmage requested a review from a team as a code owner March 13, 2020 15:26
@ghost ghost requested a review from dwoz March 13, 2020 15:26
DmitryKuzmenko
DmitryKuzmenko previously approved these changes Apr 6, 2020
@terminalmage terminalmage changed the title Add systemtest grain Add systempath grain Apr 6, 2020
@terminalmage
Copy link
Contributor Author

I rebased to resolve merge conflicts.

@terminalmage
Copy link
Contributor Author

terminalmage commented Apr 6, 2020

@DmitryKuzmenko When I rebased, it looks like I lost your review. I can't find the old review comments, either. Did you have any concerns?

One thing to note is that I used the wrong name in the Pull Request title, it should have been systempath instead of systemtest. I have renamed the PR to reflect this.

DmitryKuzmenko
DmitryKuzmenko previously approved these changes Apr 6, 2020
@DmitryKuzmenko
Copy link
Contributor

@terminalmage if I remember correctly I've just approved this. =)

@terminalmage
Copy link
Contributor Author

OK, the GitHub web interface was showing that your earlier review was a "comment" review instead of an approval, so I wanted to be sure.

... and there is now another merge conflict, so I will have to rebase again.

@terminalmage
Copy link
Contributor Author

Oh great... guess most of my PRs are going to need a rebase now that this harebrained quest to use black has been pushed through.

Good to see that the important things are getting done... 🙄

@DmitryKuzmenko
Copy link
Contributor

Yep, unfortunately.

This provides a grain like pythonpath, only for the system path. In
other words, it's the value of the PATH environment variable, only
formatted as a list of directories.
@terminalmage
Copy link
Contributor Author

Looks like you'll need to re-review, again.

DmitryKuzmenko
DmitryKuzmenko previously approved these changes Apr 7, 2020
@dwoz dwoz merged commit 991f174 into saltstack:master Apr 13, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@terminalmage terminalmage deleted the issue49049 branch February 13, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grains: path (string) vs. pythonpath (array)
4 participants