Merged
Conversation
Contributor
Author
DmitryKuzmenko
previously approved these changes
Apr 2, 2020
Contributor
|
@mchugh19 could you please resolve merge conflicts? |
dwoz
approved these changes
Apr 18, 2020
This was referenced Apr 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When state.py runs the _run_check function to validate unless/onlyif, the resulting output can include a list as a comment:
This list was breaking the state output when test=True with retry, which assumed any existing comments would already be strings. This PR add
six.text_typecasting to to string formatting to support other input types.What issues does this PR fix or reference?
#54501
Previous Behavior
Running a state with included unless and retry with
test=Truewould result in crash:New Behavior
Output is rendered as expected:
Tests written?
Yes
Commits signed with GPG?
No