Add setting for forcing refresh in zypper #56419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
agraul
force-pushed
the
add-option-disable-zypper-force-refresh
branch
from
9be7bf7 to
7bd6e14
Compare
brejoc
approved these changes
Mar 20, 2020
brejoc
suggested changes
Mar 20, 2020
salt/modules/zypperpkg.py
Outdated
Contributor
There was a problem hiding this comment.
Oh, wait a sec. I think the root kwarg is not yet introducted here. Could you check that please?
Collaborator
Author
There was a problem hiding this comment.
You are correct, that will be introduced with #54954
agraul
force-pushed
the
add-option-disable-zypper-force-refresh
branch
from
7bd6e14 to
27c6bfe
Compare
The default will still be forcing refresh to keep existing setups working. 1. Pillar option to turn off force refresh ``` zypper: refreshdb_force: false ``` 2. Cmdline option to force refresh. ``` salt '*' pkg.refresh_db [force=true|false] ``` The cmdline option will override the pillar as well. Co-authored-by: Alexander Graul <agraul@suse.com>
agraul
force-pushed
the
add-option-disable-zypper-force-refresh
branch
from
27c6bfe to
ea81719
Compare
brejoc
approved these changes
Apr 20, 2020
dwoz
approved these changes
Apr 23, 2020
tacerus
added a commit
to openSUSE/heroes-salt
that referenced
this pull request
Oct 30, 2023
By default, all zypper calls are run with --force. This is not necessary and wastes time. Reference: saltstack/salt#56419 Signed-off-by: Georg Pfuetzenreuter <georg.pfuetzenreuter@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently
salt '*' pkg.refresh_dbwill always callzypper refreshwith--forcewhenzypperis used as the backend. With this PR, this behavior can be controlled. It leaves the default as it is, but allows a CLI flag and/or a pillar entry to control if a repository is refreshed with--force.What issues does this PR fix or reference?
Previous Behavior
salt '*' pkg.refresh_db->zypper refresh --forceNew Behavior
salt '*' pkg.refresh_db->zypper refresh --forcesalt '*' pkg.refresh_db force=true->zypper refresh --forcesalt '*' pkg.refresh_db force=false->zypper refreshAlternatively, a pillar setting can be used (which is overridden by the CLI option):
Tests written?
Yes
Commits signed with GPG?
Yes