-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Support annotated tags in pygit2 git provider #56481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@afischer-opentext-com thank you for PR. The code looks good for me. Thanks for the test. Could you please check my review comments? |
|
@afischer-opentext-com the tests failures are related. Could you please protect the test to run in non-pygit2 supported environments? You can find an example here: salt/tests/unit/fileserver/test_gitfs.py Lines 564 to 565 in 5c450f3
|
|
@DmitryKuzmenko , is everything okay with the Jenkins host? I tried to look at the failured jobs but found so far no evidence that the changes are responsible for this. I have to admit not every log was accessible and some jobs are still running (e.g. Windows 2019), even if reported as failure here. |
|
re-run full amazon2-py2 |
|
Thank you! The left two jobs seem to be again timeout related. |
|
@afischer-opentext-com could you please resolve merge conflicts? |
What does this PR do?
This PR adds a fix for Issue #56451
What issues does this PR fix or reference?
#56451
Previous Behavior
Using annotated tags with PyGit2 as backend for the gitfs_remote feature just did not work as checkout failed.
New Behavior
Using annotated tags with PyGit2 as backend for the gitfs_remote feature is possible, checkouts work.
Tests written?
Yes
Commits signed with GPG?
Yes