Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue and PR templates, add config, stale bot not #56485

Merged
merged 21 commits into from
Apr 10, 2020

Conversation

sagetherage
Copy link
Contributor

What does this PR do?

Uses GitHub templates for [Bug] and [Feature Request] adds labels, easier to find by syntax search, adds syntax to PR template Fixes: to close issues linked with PRs as stated in the Contributing Guidelines, plus adds a config file with links for questions and discussions.

What issues does this PR fix or reference?

Fixes: #55853

Tests written?

No

Commits signed with GPG?

Yes

@sagetherage sagetherage requested a review from a team as a code owner March 31, 2020 02:56
@ghost ghost requested a review from waynew March 31, 2020 02:57
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a missing e 🙃

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
fix misspelling

Co-Authored-By: Wayne Werner <waynejwerner@gmail.com>
Ch3LL
Ch3LL previously approved these changes Mar 31, 2020
@Ch3LL Ch3LL self-assigned this Mar 31, 2020
Added security email for contact links
Added wording that if this is an addition or big change to use the SEP process and link
@max-arnold
Copy link
Contributor

May I suggest adding the following snippet to the versions report section to make it collapsed by default?

<details><summary>salt --versions-report</summary>

```
PASTE HERE
```
</details>

Another suggestion is to consider adding the Docs & changelog written? section to the PR template (in order to improve the docs coverage).

add docs and changelog question to PR template
update configuration to not close issues
@bryceml
Copy link
Contributor

bryceml commented Apr 3, 2020

#56075

could probably be taken care of on this pr and that one closed.

I'm not 100% sure if we want to point to the master docs for development documentation, but we should decide that so we can either merge or close #56075

update PR template to include the correct URL to be master not latest
@sagetherage
Copy link
Contributor Author

sagetherage commented Apr 3, 2020

@dwoz when you review this for merging, please comment on the URL change.

@sagetherage sagetherage requested a review from waynew April 6, 2020 22:09
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will render the GFM checkbox?

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
Co-Authored-By: Wayne Werner <waynejwerner@gmail.com>
@sagetherage sagetherage requested a review from waynew April 6, 2020 22:37
@sagetherage sagetherage changed the title Update issue and PR templates, add config Update issue and PR templates, add config, stale bot not Apr 7, 2020
@dwoz dwoz merged commit 50a7ac0 into saltstack:master Apr 10, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update issue template to the latest in GitHub
6 participants