Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ssh_pre_flight roster option #56488

Merged
merged 7 commits into from
Apr 11, 2020
Merged

Add new ssh_pre_flight roster option #56488

merged 7 commits into from
Apr 11, 2020

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Mar 31, 2020

What does this PR do?

Add new roster option ssh_pre_flight. This will allow a user to run a script before other salt-ssh commands are run. This script will only run if the thin_dir does not exist.

What issues does this PR fix or reference?

saltstack/community#45

Tests written?

Yes

Commits signed with GPG?

Yes

@Ch3LL Ch3LL requested a review from a team as a code owner March 31, 2020 19:24
@ghost ghost requested a review from cmcmarrow March 31, 2020 19:24
@Ch3LL Ch3LL added the ZRelease-Sodium retired label label Mar 31, 2020
@Ch3LL Ch3LL force-pushed the pre_ssh branch 2 times, most recently from 3de08b9 to d0a7217 Compare April 8, 2020 20:38
DmitryKuzmenko
DmitryKuzmenko previously approved these changes Apr 9, 2020
Copy link
Contributor

@DmitryKuzmenko DmitryKuzmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor review comments.

doc/ref/configuration/master.rst Outdated Show resolved Hide resolved
salt/client/ssh/__init__.py Outdated Show resolved Hide resolved
@dwoz dwoz merged commit 21a7202 into saltstack:master Apr 11, 2020
@sagetherage sagetherage added this to Done in Sodium May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
No open projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants