Merged
Conversation
ghost
requested a review
from 
twangboy
added
ZRelease-Sodium
Ch3LL
suggested changes
Apr 1, 2020
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
Looks like there are a couple failing tests.
Also Can you update the changelog and the sodium release notes with this new feature?
I think there would be added value in adding an integration test here as well to coincide with the unit tests?
Ch3LL
previously approved these changes
Apr 9, 2020
Contributor
|
@twangboy looks like it needs to be rebased and run black against this PR. Unfortunately I cannot see the test results so we will see the results after the rebase |
Contributor
|
This also links here ... |
cmcmarrow
previously approved these changes
Apr 15, 2020
twangboy
force-pushed
the
pending_reboot
branch
from
16e8b7b to
09f112c
Compare
Adds pending_reboot graint Adds new win_system salt util Adds tests for new grain Adds tests for new salt util
These have been moved to the win_system salt util and are being tested there
twangboy
force-pushed
the
pending_reboot
branch
from
a716c97 to
d1e5c9b
Compare
dwoz
approved these changes
Apr 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new
pending_rebootgrain for Windows systems.This moves code from many functions in the
salt.modules.win_systemexecution module to a newsalt.utils.win_systemsalt util. This code used by the new grain to determine if the system needs to be rebooted and must be available on minion start.Tests written?
Yes
Commits signed with GPG?
Yes