Add "salt" beacon

[jtraub91]

What does this PR do?

Adds new beacon: salt_monitor

What issues does this PR fix or reference?

Closes #56461

New Behavior

Allows user to specify one or more salt function (optionally with args / kwargs) to execute every beacon interval. The beacon will fire an event only if the return from its function is "truthy" and the event will include the function call (with args / kwargs, if applicable), as well as the return data.

Tests written?

Yes

Commits signed with GPG?

No

[jtraub91]

Did anyone get a chance to look at this PR?

[jtraub91]

@twangboy I fixed the failing tests. Can this PR be reviewed, please ?

[jtraub91]

@twangboy bump

[jtraub91]

@xeacott Does your approval mean this will go into Aluminum? Sorry to bug ya, but I'm just curious and wanted to make sure this gets included before it becomes too out of date with master.

[xeacott]

@jtraub91 Unfortunately no; we have a traditional ruling in the Core team that most PR's require 3 approvals to be considered "done done" by us. I will kindly ping @sagetherage as she can provide a much better answer about this getting Aluminum.

[sagetherage]

Since @s0undt3ch requested changed I will ask for his re-review and I have updated this with master so it is running tests again, then likely it can be merged, these labels will also help :)

[sagetherage]

how many reviewers? well, if tests are passing and tests written, docs, and changelog then only 1 review is needed, but we do like review from those that have requested changes, and 3 approvals is mandatory for anything that doesn't have all of those - clearer? Maybe, I have labeled so Megan can review for merge.

[max-arnold]

Apparently, the indentation after the salt_fun keyword should be increased:

beacons:
  salt_monitor:
    - salt_fun:
      - slsutil.renderer:
          args:
            - salt://states/apache.sls
          kwargs:
            - default_renderer: jinja
      - test.ping
    - interval: 3600  # seconds

[jtraub91]

@max-arnold yes good catch that was a typo in the docstring! 😳