Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #53622 to master (runners.git_pillar: Also match the repo parameter against the repo name) #56605

Merged
merged 1 commit into from
May 18, 2020

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Apr 10, 2020

What does this PR do?

Port #53622 to master (with tests added).

salt/runners/git_pillar.py Outdated Show resolved Hide resolved
@DmitryKuzmenko
Copy link
Contributor

@sathieu thank you for porting this to master. I understand that the original PR contains no tests but currently our testing strategy is changed: we don't merge anything not covered with at least regression tests. Could you please write one for this?

@sathieu sathieu force-pushed the git_pillar_update_by_name_master branch 3 times, most recently from 9183235 to 25956e8 Compare May 14, 2020 15:17
@sathieu sathieu force-pushed the git_pillar_update_by_name_master branch from 25956e8 to a2e9fc9 Compare May 14, 2020 18:59
@sathieu sathieu requested a review from DmitryKuzmenko May 14, 2020 18:59
@sathieu
Copy link
Contributor Author

sathieu commented May 14, 2020

@DmitryKuzmenko Please review again. Tests added.

@dwoz dwoz merged commit 00cb3ff into saltstack:master May 18, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 19, 2020
@sathieu sathieu deleted the git_pillar_update_by_name_master branch May 30, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants