Port #53622 to master (runners.git_pillar: Also match the repo parameter against the repo name)#56605
Merged
Conversation
ghost
requested a review
from 
DmitryKuzmenko
suggested changes
Apr 10, 2020
Contributor
|
@sathieu thank you for porting this to master. I understand that the original PR contains no tests but currently our testing strategy is changed: we don't merge anything not covered with at least regression tests. Could you please write one for this? |
sathieu
force-pushed
the
git_pillar_update_by_name_master
branch
3 times, most recently
from
9183235 to
25956e8
Compare
sathieu
force-pushed
the
git_pillar_update_by_name_master
branch
from
25956e8 to
a2e9fc9
Compare
Contributor
Author
|
@DmitryKuzmenko Please review again. Tests added. |
DmitryKuzmenko
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Port #53622 to master (with tests added).