[master] Support in host module and state module for comments#56614
Merged
dwoz merged 2 commits intosaltstack:masterfrom Apr 18, 2020
Merged
[master] Support in host module and state module for comments#56614dwoz merged 2 commits intosaltstack:masterfrom
dwoz merged 2 commits intosaltstack:masterfrom
Conversation
ghost
requested a review
from 
Updating host module and state module to support comments. Adding new module and state module tests for comment changes.
garethgreenaway
force-pushed
the
52185_master_hosts_allow_comments
branch
from
5db2497 to
3cfbb4f
Compare
dwoz
approved these changes
Apr 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updating host module and state module to support comments. Adding new module and state module tests for comment changes.
What issues does this PR fix or reference?
Fixes: #52185
Docs & changelog written?
Yes/No
Tests written?
[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.