Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Support in host module and state module for comments #56614

Merged

Conversation

garethgreenaway
Copy link
Contributor

What does this PR do?

Updating host module and state module to support comments. Adding new module and state module tests for comment changes.

What issues does this PR fix or reference?

Fixes: #52185

Docs & changelog written?

Yes/No

  • [ Yes] Docs
  • [ No] Changelog

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner April 12, 2020 22:02
@ghost ghost requested a review from twangboy April 12, 2020 22:02
Updating host module and state module to support comments. Adding new module and state module tests for comment changes.
@garethgreenaway garethgreenaway force-pushed the 52185_master_hosts_allow_comments branch from 5db2497 to 3cfbb4f Compare April 12, 2020 22:09
@Ch3LL Ch3LL removed the request for review from a team April 15, 2020 14:12
@dwoz dwoz merged commit a5ec2df into saltstack:master Apr 18, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hosts: Allow to add comments
3 participants