Add new salt-ssh set_path option #56627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
@Ch3LL The windows tests have failures. |
Ch3LL
changed the title
Ch3LL
changed the title
dwoz
approved these changes
Apr 18, 2020
s0undt3ch
added a commit
that referenced
this pull request
Aug 14, 2020
s0undt3ch
added a commit
that referenced
this pull request
Aug 18, 2020
s0undt3ch
added a commit
that referenced
this pull request
Aug 30, 2020
s0undt3ch
added a commit
that referenced
this pull request
Aug 31, 2020
s0undt3ch
added a commit
that referenced
this pull request
Sep 1, 2020
s0undt3ch
added a commit
that referenced
this pull request
Sep 2, 2020
s0undt3ch
added a commit
that referenced
this pull request
Sep 3, 2020
s0undt3ch
added a commit
to s0undt3ch/salt
that referenced
this pull request
Sep 5, 2020
s0undt3ch
added a commit
to s0undt3ch/salt
that referenced
this pull request
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds new
set_pathoption for salt-ssh to set the PATH environment variable used in the salt-ssh shim.What issues does this PR fix or reference?
Fixes: #56599 - the mac tests are failing because python is not in the path.
Previous Behavior
Could not set the PATH when running salt-ssh.
New Behavior
Can set the PATH environment variable when running salt-ssh. This helps solve problems associated when python is not in your current path setting.
Merge requirements satisfied?
Commits signed with GPG?
Yes