Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add win_wua.installed to the win_wua module #56637

Merged
merged 14 commits into from
Apr 23, 2020

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Apr 14, 2020

What does this PR do?

Adds win_wua.installed function to win_wua module. The function will return a list of updates that apply to the current build of Windows.

What issues does this PR fix or reference?

Fixes: #56640

Previous Behavior

No way to get a list of installed updates

New Behavior

Now you can get a list of installed updates

Merge requirements satisfied?

  • Docs
  • Changelog
  • Tests written/updated

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from a team as a code owner April 14, 2020 18:13
@ghost ghost requested a review from Ch3LL April 14, 2020 18:13
@twangboy twangboy changed the title Adds win_wua.installed to the win_wua module Add win_wua.installed to the win_wua module Apr 14, 2020
xeacott
xeacott previously approved these changes Apr 14, 2020
@Ch3LL
Copy link
Contributor

Ch3LL commented Apr 14, 2020

Can we get an associated issue with this PR? Also there are some failing doc and pre-commit tests

Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like online's documentation and the kwarg conflict. I'm not sure what is suppose to be the default but I was wondering if it will change teh default behavior for people using this module?

salt/modules/win_wua.py Outdated Show resolved Hide resolved
salt/modules/win_wua.py Outdated Show resolved Hide resolved
salt/modules/win_wua.py Outdated Show resolved Hide resolved
salt/utils/win_update.py Outdated Show resolved Hide resolved
salt/utils/win_update.py Outdated Show resolved Hide resolved
@Ch3LL Ch3LL self-assigned this Apr 14, 2020
@twangboy
Copy link
Contributor Author

twangboy commented Apr 14, 2020

@Ch3LL There is no corresponding issue. It's a requirement for the VWin team. Going online is the default behavior. The ability to scan in an offline mode is part of the new feature.

@Ch3LL
Copy link
Contributor

Ch3LL commented Apr 14, 2020

can we add one for tracking purposes? If someone wants to request the same feature, they will be able to see a feature request was already added.

Also just a clarification question. it looks like you made the default for online to be True. Does this change default behavior for users?

@twangboy
Copy link
Contributor Author

Online True was the default. This adds the ability to scan without going out to Microsoft or a WSUS server.

@twangboy
Copy link
Contributor Author

Linked to Issue

@twangboy
Copy link
Contributor Author

@xeacott That's actually for the pending_reboot grain

@xeacott
Copy link
Contributor

xeacott commented Apr 14, 2020

Oh yeah, sorry put that in the wrong PR

@Ch3LL
Copy link
Contributor

Ch3LL commented Apr 15, 2020

thanks for adding the issue @twangboy :)

looks like there are some legit test failures here.

@dwoz dwoz merged commit efa84d1 into saltstack:master Apr 23, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@sagetherage sagetherage added this to Done in Sodium May 19, 2020
@twangboy twangboy deleted the win_update_installed branch May 26, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRelease-Sodium retired label
Projects
No open projects
Sodium
  
Done
Development

Successfully merging this pull request may close these issues.

Add ability to only list Updates that are installed.
5 participants