Skip to content

Add win_wua.installed to the win_wua module - #56637

Merged
dwoz merged 14 commits into
saltstack:masterfrom
twangboy:win_update_installed
Apr 23, 2020
Merged

dwoz merged 14 commits into
saltstack:masterfrom
twangboy:win_update_installed

Conversation

@twangboy

@twangboy twangboy commented Apr 14, 2020 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds win_wua.installed function to win_wua module. The function will return a list of updates that apply to the current build of Windows.

What issues does this PR fix or reference?

Fixes: #56640

Previous Behavior

No way to get a list of installed updates

New Behavior

Now you can get a list of installed updates

Merge requirements satisfied?

  • Docs
  • Changelog
  • Tests written/updated

Commits signed with GPG?

Yes

@twangboy
twangboy requested a review from a team as a code owner April 14, 2020 18:13
@ghost
ghost requested a review from Ch3LL April 14, 2020 18:13
@twangboy twangboy changed the title Adds win_wua.installed to the win_wua module Add win_wua.installed to the win_wua module Apr 14, 2020
xeacott
xeacott previously approved these changes Apr 14, 2020
@Ch3LL

Ch3LL commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

Can we get an associated issue with this PR? Also there are some failing doc and pre-commit tests

@Ch3LL Ch3LL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like online's documentation and the kwarg conflict. I'm not sure what is suppose to be the default but I was wondering if it will change teh default behavior for people using this module?

Comment thread salt/modules/win_wua.py Outdated
Comment thread salt/modules/win_wua.py Outdated
Comment thread salt/modules/win_wua.py Outdated
Comment thread salt/utils/win_update.py Outdated
Comment thread salt/utils/win_update.py Outdated
@Ch3LL Ch3LL self-assigned this Apr 14, 2020
@twangboy

twangboy commented Apr 14, 2020 •

Copy link
Copy Markdown
Contributor Author

@Ch3LL There is no corresponding issue. It's a requirement for the VWin team. Going online is the default behavior. The ability to scan in an offline mode is part of the new feature.

@Ch3LL

Ch3LL commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

can we add one for tracking purposes? If someone wants to request the same feature, they will be able to see a feature request was already added.

Also just a clarification question. it looks like you made the default for online to be True. Does this change default behavior for users?

@twangboy

Copy link
Copy Markdown
Contributor Author

Online True was the default. This adds the ability to scan without going out to Microsoft or a WSUS server.

@twangboy

Copy link
Copy Markdown
Contributor Author

Linked to Issue

@twangboy

Copy link
Copy Markdown
Contributor Author

@xeacott That's actually for the pending_reboot grain

@xeacott

xeacott commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

Oh yeah, sorry put that in the wrong PR

@Ch3LL

Ch3LL commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

thanks for adding the issue @twangboy :)

looks like there are some legit test failures here.

@twangboy
twangboy force-pushed the win_update_installed branch from 6256c28 to 23dfd61 Compare April 17, 2020 16:41
@dwoz
dwoz merged commit efa84d1 into saltstack:master Apr 23, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@twangboy
twangboy deleted the win_update_installed branch May 26, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ZRelease-Sodium retired label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to only list Updates that are installed.

5 participants